Skip to content

Conversation

@zac-nixon
Copy link
Collaborator

Issue

#4391

Description

The Ingress API will discover certs for all host names, on the listener and each rule. We missed that for the Gateway API, so I am back porting the same logic.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zac-nixon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 22, 2025
@zac-nixon zac-nixon force-pushed the znixon/gw-cert-discovery branch from 7fd909d to b340459 Compare October 22, 2025 17:44
@zac-nixon zac-nixon force-pushed the znixon/gw-cert-discovery branch from b340459 to 4cbb84c Compare October 22, 2025 17:46
@shuqz
Copy link
Collaborator

shuqz commented Oct 22, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2025
@k8s-ci-robot k8s-ci-robot merged commit fbe59ea into kubernetes-sigs:main Oct 22, 2025
9 checks passed
@zac-nixon zac-nixon deleted the znixon/gw-cert-discovery branch October 23, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants