-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: revert alpine base image change to fix DNS issue #1418
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6794a44
to
570214e
Compare
/retest |
/cherrypick release-1.28 |
@andyzhangx: new pull request created: #1420 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-1.27 |
@andyzhangx: new pull request created: #1421 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-1.26 |
@andyzhangx: new pull request created: #1422 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-1.24 |
@andyzhangx: new pull request created: #1423 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix: revert alpine base image change to fix DNS issue
revert of #1175
On some k8s clusters with customer vnet setting, cifs mount cannot resolve DNS while nslookup works well, and switch to debian-base image works.
cifs mount is using getaddrinfo invoked by resolve_host which finally depends on glibc implementation on debian based image, while on alpine image, it's using musl, getaddrinfo may not handle DNS well in lots of cases: github.com not reachable from alpine image alpinelinux/docker-alpine#155, so we decided to using debian base image which are using glibc lib.
other reference: nodejs/docker-node#1030 (comment)
btw, though alpine is updating musl lib which could solve dns-over-tcp (on alpine 3.18), while it's still not suggested to use alpine image since we don't know whether there is other potential dns issue: https://news.ycombinator.com/item?id=35056594
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: