✨ Cache architecture for each instance type in memory to avoid unnecessary AWS API requests #5764
+86
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
With the MachinePool Machines feature gate turned on, we now see a lot more reconciliation queueing on large MCs due to reconciling a lot of
AWSMachineobjects. This PR was a low-hanging fruit: theDescribeInstanceTypesAWS request is 100% cacheable.This uses CAPI's caching helper and uses a very long caching duration as I don't expect the instance type to architecture mapping to change within AWS.
Confirmed working in our fork already (giantswarm#638).
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):n/a
Special notes for your reviewer:
Checklist:
Release note: