Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace some usage of Azure/go-autorest #3337

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Replace some usage of Azure/go-autorest #3337

merged 1 commit into from
Mar 27, 2023

Conversation

mboersma
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Replaces some usage of the soon-to-be-unsupported Azure/go-autorest package.

Which issue(s) this PR fixes:

Refs #2974

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 20, 2023
@mboersma mboersma force-pushed the remove-go-autorest branch from a7fc477 to 5c28bc0 Compare March 20, 2023 19:19
CecileRobertMichon
CecileRobertMichon reviewed Mar 20, 2023
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 61e2e7b9e37d6761866f492c0b77c5a4056f0b17

jackfrancis
jackfrancis approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2023
@mboersma
Copy link
Contributor Author

/hold
/test pull-cluster-api-provider-azure-e2e-optional

To make sure this didn't break anything related to VMSS Flex.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2023
@CecileRobertMichon
Copy link
Contributor

Flex passed but clusterclass failed...

/retest

@CecileRobertMichon
Copy link
Contributor

CecileRobertMichon commented Mar 21, 2023 •
edited
Loading 

  -- Original Error: Code="PublicIPCountLimitReached" Message="Cannot create more than 100 public IP addresses for this subscription in this region." Details=[]'

/retest

@mboersma
Copy link
Contributor Author

/retest

1 similar comment
@mboersma
Copy link
Contributor Author

/retest

@mboersma
Copy link
Contributor Author

I don't think the -optional test will pass until #3322 merges, since it's the ClusterClass failure.

@CecileRobertMichon
Copy link
Contributor

/retest

1 similar comment
@mboersma
Copy link
Contributor Author

/retest

@mboersma
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit a2ddd67 into kubernetes-sigs:main Mar 27, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Mar 27, 2023
@mboersma mboersma deleted the remove-go-autorest branch March 27, 2023 17:12
@dthorsen dthorsen mentioned this pull request May 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@jackfrancis jackfrancis jackfrancis approved these changes

@willie-yao willie-yao Awaiting requested review from willie-yao

Assignees

@jackfrancis jackfrancis

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
4 participants
@mboersma @k8s-ci-robot @CecileRobertMichon @jackfrancis