Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove last uses of old Azure SDK for Go #4425

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Remove last uses of old Azure SDK for Go #4425

merged 1 commit into from
Jan 3, 2024

Conversation

mboersma
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Removes the final two vestiges of the "track 1" version of Azure SDK for Go in the CAPZ codebase.

Which issue(s) this PR fixes:
Refs #3409

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 28, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 28, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 28, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1792fd4) 61.97% compared to head (d3bb7db) 61.97%.
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4425   +/-   ##
=======================================
  Coverage   61.97%   61.97%           
=======================================
  Files         188      188           
  Lines       18765    18765           
=======================================
  Hits        11630    11630           
  Misses       6497     6497           
  Partials      638      638

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mboersma
Copy link
Contributor Author

/retest

@mboersma mboersma added this to the v1.13 milestone Dec 29, 2023
mboersma
mboersma commented Jan 2, 2024
View reviewed changes
version/version.go
@@ -58,7 +56,7 @@ func Get() Info {
GoVersion: runtime.Version(),
Compiler: runtime.Compiler,
Platform: fmt.Sprintf("%s/%s", runtime.GOOS, runtime.GOARCH),
AzureSdkVersion: azuresdkversion.Number,
AzureSdkVersion: "SDK track2",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no single version string provided any longer for the SDK (except arguably in an internal package that's not accessible). So I think all we can do is hard-code it from now on.

CecileRobertMichon
CecileRobertMichon reviewed Jan 2, 2024
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 60ba6ab0088de92aada39093e337fb876d538f22

nojnhuh
nojnhuh reviewed Jan 3, 2024
View reviewed changes
Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit 10266e5 into kubernetes-sigs:main Jan 3, 2024
28 checks passed
@mboersma mboersma deleted the sdkv1-begone branch January 3, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojnhuh nojnhuh nojnhuh left review comments

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@marosset marosset Awaiting requested review from marosset

@sonasingh46 sonasingh46 Awaiting requested review from sonasingh46

Assignees

@CecileRobertMichon CecileRobertMichon

@nojnhuh nojnhuh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.
4 participants
@mboersma @k8s-ci-robot @CecileRobertMichon @nojnhuh