Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore AMMP-converges-to-failed-ready test spec #4555

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Restore AMMP-converges-to-failed-ready test spec #4555

merged 1 commit into from
Feb 13, 2024

Conversation

willie-yao
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR restores the AMMP-converges-to-failed-ready test spec that was removed in #3857.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3893

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 9, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (38a5395) 62.45% compared to head (e8eca49) 62.46%.
Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4555      +/-   ##
==========================================
+ Coverage   62.45%   62.46%   +0.01%     
==========================================
  Files         192      192              
  Lines       15393    15393              
==========================================
+ Hits         9614     9616       +2     
+ Misses       5119     5117       -2     
  Partials      660      660

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willie-yao
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e-aks

1 similar comment
@willie-yao
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e-aks

@willie-yao willie-yao changed the title WIP: Restore AMMP-converges-to-failed-ready test spec Restore AMMP-converges-to-failed-ready test spec Feb 12, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2024
@willie-yao
Copy link
Contributor Author

/assign @mboersma since you worked on removing the test

mboersma
mboersma approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @willie-yao!

test/e2e/aks_public_ip_prefix.go
g.Expect(cond).NotTo(BeNil())
g.Expect(cond.Status).To(Equal(corev1.ConditionFalse))
g.Expect(cond.Reason).To(Equal(infrav1.FailedReason))
g.Expect(cond.Message).To(ContainSubstring("PublicIpPrefixOutOfIpAddressesForVMScaleSet"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the error message we used to expect here changed (with SDKv2 I'm assuming).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup it's a more detailed error message than the previous one, but I think it's the same error.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I'd bet this same string appeared in the last error message too. At the very least, that string seems like a good indication of what I expect the error here to be.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d848685ca710b8ac51c6d6a1916d3e53a1ed992b

@mboersma
Copy link
Contributor

/assign @nojnhuh

nojnhuh
nojnhuh reviewed Feb 13, 2024
View reviewed changes
Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit aff1d2d into kubernetes-sigs:main Feb 13, 2024
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojnhuh nojnhuh nojnhuh left review comments

@mboersma mboersma mboersma approved these changes

@Jont828 Jont828 Awaiting requested review from Jont828

Assignees

@mboersma mboersma

@nojnhuh nojnhuh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
CAPZ Planning
Archived in project
Milestone
v1.14
Development

Successfully merging this pull request may close these issues.

Investigate AMMP-converges-to-failed-ready test spec
4 participants
@willie-yao @k8s-ci-robot @mboersma @nojnhuh