Update pre commit hooks to check spelling and lint-fix on pre commit

[bryan-cox]

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR:

• moves the pre-commit hook for spellcheck from pre-push to pre-commit
• adds make lint-fix to the pre-commit hook

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
N/A

Special notes for your reviewer:

TODOs:

• squashed commits
• includes documentation
• adds unit tests
• cherry-pick candidate

Release note:

None

[bryan-cox]

Hey @nawazkh 👋🏻 - I can't remember if we put the spellcheck on pre-push for some reason previously but this PR moves it to pre-commit so those are caught up front.

I also added make lint-fix. I was able to push go files that were not gci-ed properly. That should probably be caught before submitting a PR as well.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.41%. Comparing base (0f04d8d) to head (30c0b16).
Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5440   +/-   ##
=======================================
  Coverage   52.41%   52.41%           
=======================================
  Files         272      272           
  Lines       29361    29361           
=======================================
  Hits        15390    15390           
  Misses      13165    13165           
  Partials      806      806           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nawazkh]

A welcome change imo. Whats the total time to completion you see upon adding these two additional stages to pre-commit ?

[bryan-cox]

Whoops I meant to add make verify-codespell initially. It's been added.

I did a quick test of 3 commits without the PR and 3 commits with the PR. It's about 6 seconds slower with the PR. The average times were:

• without the PR 0.47s
• with the PR 6.39s

[nawazkh]

What do you say if we move make verify-codespell to pre-push stage ?

I would love to keep the git commit time to be as short as possible.
Besides, we do run all the verify tests as part of a job. Reference conversation: #5213

[bryan-cox]

Sure, the removed a second off the time.

[bryan-cox]

Change has been pushed

[nawazkh]

I tested make verify-lint in my local and it took the system 2m 24s to complete it.
What do you say to moving verify-lint to pre-push stage as well? Since verify-lint is not commit restricted, it should still check the linter-errors in complete changes.

Sorry, not trying to be a bum about this 😶‍🌫️ I am quite inclined on having faster commit times.

[bryan-cox]

Wow 2m 🤯

Sure I can move it to pre-push.

[bryan-cox]

Updated

[nawazkh]

Thank you Bryan!
/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 111d2c9b87c66a703e92129ee05e2cf78c18080e

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nawazkh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nawazkh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment