Skip to content

📖 Document providers that support deletion single MachinePool Machines #12872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

📖 Document providers that support deletion single MachinePool Machines #12872

wants to merge 1 commit into from
+9 −7

Conversation

@AndiDog
Copy link
Contributor

@AndiDog AndiDog commented Oct 17, 2025

What this PR does / why we need it:

Follow-up for #12797, as suggested by @richardcase

/area machinepool

@k8s-ci-robot k8s-ci-robot added area/machinepool Issues or PRs related to machinepools cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 17, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 17, 2025
@AndiDog AndiDog mentioned this pull request Oct 17, 2025
Merged
fabriziopandini
fabriziopandini reviewed Oct 17, 2025
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 531bcbbb06b10af71fb50b14c08dccfa1cbb43cd

fabriziopandini
fabriziopandini reviewed Oct 17, 2025
View reviewed changes
docs/book/src/tasks/experimental-features/machine-pools.md
| Provider | Implementations | Status | MachinePool Machines support |
| --- | --- | --- | --- |
| [AWS](https://cluster-api-aws.sigs.k8s.io/topics/machinepools.html) | `AWSManagedMachinePool`<br> `AWSMachinePool`<br>`ROSAMachinePool` | Implemented | Yes; has support for deletion of single machine |
| [Azure](https://capz.sigs.k8s.io/self-managed/machinepools) | `AzureASOManagedMachinePool`<br> `AzureManagedMachinePool`<br> `AzureMachinePool` | Implemented | Yes; unknown support for deletion of single machine |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be @mboersma can help in qualifying unknown here

docs/book/src/tasks/experimental-features/machine-pools.md Outdated
| [AWS](https://cluster-api-aws.sigs.k8s.io/topics/machinepools.html) | `AWSManagedMachinePool`<br> `AWSMachinePool`<br>`ROSAMachinePool` | Implemented | Yes; has support for deletion of single machine |
| [Azure](https://capz.sigs.k8s.io/self-managed/machinepools) | `AzureASOManagedMachinePool`<br> `AzureManagedMachinePool`<br> `AzureMachinePool` | Implemented | Yes; unknown support for deletion of single machine |
| [GCP](https://github.com/kubernetes-sigs/cluster-api-provider-gcp/pull/1506) | `GCPMachinePool` | In Progress | Unknown |
| [OCI](https://oracle.github.io/cluster-api-provider-oci/managed/managedcluster.html) | `OCIManagedMachinePool`<br> `OCIMachinePool` | Implemented | Yes; unknown support for deletion of single machine |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrt to unknown here, what about asking in cluster-api-oci?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reaching out. Individual machines in the pool cannot be selectively deleted as far as I'm aware. You can only scale the pool as a whole.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, included that here.

@mboersma any idea whether CAPZ supports deletion of single machines of AzureASOManagedMachinePool/AzureManagedMachinePool/AzureMachinePool?

@AndiDog AndiDog changed the title Document providers that support deletion single MachinePool Machines 📖 Document providers that support deletion single MachinePool Machines Oct 21, 2025
@AndiDog AndiDog force-pushed the mp-machines-support-docs branch from fed69a5 to 8b335bb Compare October 27, 2025 12:23
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from fabriziopandini. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardcase richardcase Awaiting requested review from richardcase

@sivchari sivchari Awaiting requested review from sivchari

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

1 more reviewer

@joekr joekr joekr left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@fabriziopandini fabriziopandini

Labels

area/machinepool Issues or PRs related to machinepools cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AndiDog @k8s-ci-robot @joekr @fabriziopandini