🌱 [WIP] Update 1.23 Kubernetes references to 1.24.0 #6480
Conversation
Signed-off-by: killianmuldoon <[email protected]>
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/L
killianmuldoon
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/test pull-cluster-api-e2e-full-main |
| | Kubernetes v1.21 + kubeadm/v1beta2 | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | | ||
| | Kubernetes v1.22 + kubeadm/v1beta2 (v0.3) kubeadm/v1beta3 (v0.4+) | | ✓ | ✓ | ✓ | ✓ | ✓ | | ||
| | Kubernetes v1.23 + kubeadm/v1beta3 | | | ✓ | ✓ | ✓ | ✓ | | ||
| | Kubernetes v1.24 + kubeadm/v1beta3 | | | ✓ | ✓ | ✓ | ✓ | |
There was a problem hiding this comment.
I assume we don't want to drop support for 1.24 in v0.4/v1alpha4 unless we have good reason to, right?
There was a problem hiding this comment.
I think it's the other way around. We don't want to add support if there is no really really good reason for it (especially given that everything v0.3/v0.4/v1.0 are out of support and we can also only claim support in v1.1 after we made sure that v1.24 works there (we have to revisit the v1.24 issue if we backported everything relevant already)
There was a problem hiding this comment.
(in the office hours a while back we decided to support v1.24 only in v1.1.x+)
| | Kubernetes v1.21 + kubeadm/v1beta2 | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | | ||
| | Kubernetes v1.22 + kubeadm/v1beta2 (v0.3) kubeadm/v1beta3 (v0.4+) | | ✓ | ✓ | ✓ | ✓ | ✓ | | ||
| | Kubernetes v1.23 + kubeadm/v1beta3 | | | ✓ | ✓ | ✓ | ✓ | | ||
| | Kubernetes v1.24 + kubeadm/v1beta3 | | | ✓ | ✓ | ✓ | ✓ | |
There was a problem hiding this comment.
I think it's the other way around. We don't want to add support if there is no really really good reason for it (especially given that everything v0.3/v0.4/v1.0 are out of support and we can also only claim support in v1.1 after we made sure that v1.24 works there (we have to revisit the v1.24 issue if we backported everything relevant already)
| | Kubernetes v1.21 + kubeadm/v1beta2 | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | | ||
| | Kubernetes v1.22 + kubeadm/v1beta2 (v0.3) kubeadm/v1beta3 (v0.4+) | | ✓ | ✓ | ✓ | ✓ | ✓ | | ||
| | Kubernetes v1.23 + kubeadm/v1beta3 | | | ✓ | ✓ | ✓ | ✓ | | ||
| | Kubernetes v1.24 + kubeadm/v1beta3 | | | ✓ | ✓ | ✓ | ✓ | |
There was a problem hiding this comment.
(in the office hours a while back we decided to support v1.24 only in v1.1.x+)
|
/retest |
|
Hm looks like CAPD doesn't work without modifications with v1.24 https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/6480/pull-cluster-api-e2e-full-main/1524035502095732736 (at a first glance) |
|
@killianmuldoon I think we have to bump to kind v0.13 given the release notes: https://github.com/kubernetes-sigs/kind/releases/tag/v0.13.0 I'm not sure if this will solve our issues already, please let me know if/when I should help debugging (I didn't take a closer look yet) With this version kind itself is using systemd cgroupdriver again, so I assume we can and should stop pinning to cgroupfs (not sure if that's mandatory to get it to work though) If we have to use different cgroupdriver per version. This might be a solution
|
killianmuldoon
force-pushed
the
update-k8s/1-24
branch
from
04da2b4 to
222a924
Compare
killianmuldoon
force-pushed
the
update-k8s/1-24
branch
from
222a924 to
fcf2bad
Compare
|
@killianmuldoon: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Thx @killianmuldoon for the work on this PR I'll close it in favor of #6513 The only thing not included is the change to version.md, I'll follow-up on that. /close |
|
@sbueringer: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: killianmuldoon [email protected]
Update Kubernetes 1.23 to 1.24 across CAPI docs and test code.
WIP / hold as we're still waiting for the kind node image to be published.
Part of: #5968