-
Notifications
You must be signed in to change notification settings - Fork 1.2k
⚠️ Add native SSA support #3253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alvaroaleman
wants to merge
5
commits into
kubernetes-sigs:main
Choose a base branch
from
alvaroaleman:ssa
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+574
−70
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
da779f9
:sparkles: Add native SSA support
alvaroaleman 3165151
Field validation
alvaroaleman 3c81fa7
Revert "Field validation"
alvaroaleman d20f30a
Explain why we don't update the namespaced client
alvaroaleman 3f2934c
Client: Force ownership supports Apply
alvaroaleman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
/* | ||
Copyright 2025 The Kubernetes Authors. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package client | ||
|
||
import ( | ||
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured" | ||
"k8s.io/apimachinery/pkg/runtime" | ||
"k8s.io/apimachinery/pkg/runtime/schema" | ||
) | ||
|
||
type unstructuredApplyConfiguration struct { | ||
*unstructured.Unstructured | ||
} | ||
|
||
func (u *unstructuredApplyConfiguration) IsApplyConfiguration() {} | ||
|
||
// ApplyConfigurationFromUnstructured creates a runtime.ApplyConfiguration from an *unstructured.Unstructured object. | ||
func ApplyConfigurationFromUnstructured(u *unstructured.Unstructured) runtime.ApplyConfiguration { | ||
return &unstructuredApplyConfiguration{Unstructured: u} | ||
} | ||
|
||
type applyconfigurationRuntimeObject struct { | ||
runtime.ApplyConfiguration | ||
} | ||
|
||
func (a *applyconfigurationRuntimeObject) GetObjectKind() schema.ObjectKind { | ||
return a | ||
} | ||
|
||
func (a *applyconfigurationRuntimeObject) GroupVersionKind() schema.GroupVersionKind { | ||
return schema.GroupVersionKind{} | ||
} | ||
|
||
func (a *applyconfigurationRuntimeObject) SetGroupVersionKind(gvk schema.GroupVersionKind) {} | ||
|
||
func (a *applyconfigurationRuntimeObject) DeepCopyObject() runtime.Object { | ||
panic("applyconfigurationRuntimeObject does not support DeepCopyObject") | ||
} | ||
|
||
func runtimeObjectFromApplyConfiguration(ac runtime.ApplyConfiguration) runtime.Object { | ||
return &applyconfigurationRuntimeObject{ApplyConfiguration: ac} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised this doesn't exist anywhere in the API machinery already today 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstream didn't want that: kubernetes/kubernetes#132194 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some pretty strong arguments against creating this in the thread there, what would the likely impact to CR users be if we decided that ApplyConfiguration through CR was only supported for concrete types and not unstructured?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess my main concern would be
How do we elevate this message to help prevent folks from shooting themselves in the foot?
In general, marshalling zero values is a bad idea, but there's a lot of legacy required fields out there without omitempty assigned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We break all existing usages of Apply in controller-runtime and make it impossible to apply objects for which you do not have the AC, for example because you read them from disk.
Its a nonsensical argument. That issue only exists if someone converts from concrete type to unstructured, there is no reason to do that. Using unstructured.Unstrucutred itself is fine, as it has no zero values. People could also use a serializer to convert from conrete type to applyconfig and the exact same issue would arise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think adding godoc to the functions here to explain that this should not be used when converting structured types to unstructured would cover us in terms of messaging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But what is the reason why anyone would ever do that? And what makes us assume that is any more likely than converting from API type to AC type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, but since it's possible, someone will probably be doing it. Since we know it causes issues, IMO it makes sense to document that this is not something we recommend.
I think I'd put this down to Hyrum's Law