Skip to content

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Oct 3, 2025

Signed-off-by: Stefan Büringer [email protected]

Part of #2374

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 3, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 3, 2025
@sbueringer sbueringer mentioned this pull request Oct 3, 2025
22 tasks
@sbueringer
Copy link
Member Author

/assign @alvaroaleman

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 3, 2025
@sbueringer sbueringer changed the title ✨ Enable PQ per default ✨ Priorityqueue: Enable per default + don't block on Get when queue is shutdown (2nd try) Oct 3, 2025
@sbueringer sbueringer force-pushed the pr-enable-pq-per-default branch 3 times, most recently from 10a58d4 to 0964f37 Compare October 5, 2025 09:41
@sbueringer sbueringer changed the title ✨ Priorityqueue: Enable per default + don't block on Get when queue is shutdown (2nd try) ✨ Priorityqueue: Enable per default Oct 5, 2025
@sbueringer sbueringer force-pushed the pr-enable-pq-per-default branch from 0964f37 to 7ef9086 Compare October 5, 2025 09:51
Signed-off-by: Stefan Büringer [email protected]
@sbueringer sbueringer force-pushed the pr-enable-pq-per-default branch from 7ef9086 to d2c0c8b Compare October 6, 2025 08:25
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 6, 2025
@sbueringer
Copy link
Member Author

@alvaroaleman Rebased, PTAL

Copy link
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel
thanks!

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 6, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c2cc67ee1bf9026ad10733fa968670345f49ffa4

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alvaroaleman,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b0b0b0f into kubernetes-sigs:main Oct 6, 2025
10 checks passed
@sbueringer sbueringer deleted the pr-enable-pq-per-default branch October 6, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants