Skip to content

validations: add exclusiveMaximum property validation - #59

Open
LoginovIlia wants to merge 1 commit into
kubernetes-sigs:mainfrom
LoginovIlia:exclusive_maximum
Open

validations: add exclusiveMaximum property validation#59
LoginovIlia wants to merge 1 commit into
kubernetes-sigs:mainfrom
LoginovIlia:exclusive_maximum

Conversation

@LoginovIlia

@LoginovIlia LoginovIlia commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

What this PR does:

Adds validation for the exclusiveMaximum field

Which issue this PR is related to:

Fixes #19

@k8s-ci-robot

k8s-ci-robot commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LoginovIlia
Once this PR has been reviewed and has the lgtm label, please assign jpbetz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 15, 2026
everettraven
everettraven requested changes May 19, 2026
View reviewed changes

@everettraven everettraven left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the very long delay for this review - I've not had much time to stay on top of things here.

Just a couple comments to address here.

Comment thread docs/validations.md Outdated
Comment thread pkg/validations/property/exclusive_maximum.go Outdated
@kubernetes-prow

kubernetes-prow Bot commented Jul 28, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LoginovIlia
Once this PR has been reviewed and has the lgtm label, please assign jpbetz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 28, 2026
@LoginovIlia
LoginovIlia requested a review from everettraven July 28, 2026 18:50
@kubernetes-prow kubernetes-prow Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 28, 2026
@kubernetes-prow kubernetes-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpbetz jpbetz Awaiting requested review from jpbetz
@everettraven everettraven Awaiting requested review from everettraven

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Property Validation: exclusiveMaximum

3 participants

@LoginovIlia @k8s-ci-robot @everettraven