Skip to content

Add anyOf property validation - #65

Open
rishh09 wants to merge 1 commit into
kubernetes-sigs:mainfrom
rishh09:anyof-validation
Open

Add anyOf property validation#65
rishh09 wants to merge 1 commit into
kubernetes-sigs:mainfrom
rishh09:anyof-validation

Conversation

@rishh09

@rishh09 rishh09 commented Jul 13, 2026

Copy link
Copy Markdown

What this PR does

Adds property compatibility validation for anyOf constraints.

The new validation:

  • flags net-new anyOf constraints
  • flags removed anyOf subschemas
  • flags changed anyOf subschemas
  • allows adding a subschema to an existing anyOf

Which issue this PR is related to

Fixes #26

Why

Adding a subschema to an existing anyOf broadens the accepted values, while net-new, removed, or changed anyOf schemas can invalidate existing users or stored resources.

Tests

  • go fmt ./...
  • go mod tidy
  • go tool -modfile tools/go.mod github.com/golangci/golangci-lint/v2/cmd/golangci-lint run
  • go test ./pkg/validations/property
  • go test ./...
  • go build -o bin/crdify main.go
  • go run ./test/suite.go --binary ./bin/crdify
  • git diff --check

@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rishh09
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla

linux-foundation-easycla Bot commented Jul 13, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: rishh09 / name: rishh09 (3af080d)

@kubernetes-prow
kubernetes-prow Bot requested review from JoelSpeed and jpbetz July 13, 2026 08:29
@kubernetes-prow kubernetes-prow Bot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 13, 2026
@kubernetes-prow

Copy link
Copy Markdown

Welcome @rishh09!

It looks like this is your first PR to kubernetes-sigs/crdify 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/crdify has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Property Validation: anyOf

1 participant