-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the scorecard github action and its badge #4674
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: ivan katliarchuk <[email protected]>
Hi @ivankatliarchuk. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: ivan katliarchuk <[email protected]>
Co-authored-by: Michel Loiseleur <[email protected]>
All my reply are in pending state. Not sure bug or smth. ![]() ![]() |
Co-authored-by: Michel Loiseleur <[email protected]>
/lgtm |
I am not sure I like to have this added to the project. From what I can see, the OpenSSF scorecard is really not that great and gives you easily a wrong score for things that improve the project by a very small amount. We currently get a 6.9 (https://securityscorecards.dev/viewer/?uri=github.com/kubernetes-sigs/external-dns) which seems to be kinda bad, but the results need to be interpreted. I am not sure or maybe I even doubt that our users will be able to determine if it's something to worry about or not. A similar discussion has been done in the curl project. For now, I'll put this on hold. /hold |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
Fixes #4673
PR to add the Scorecard GitHub Action and its badge in the README file.
Similar PR helm/helm#13233
Checklist