Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: OVH provider: avoid failing on 404 #4844

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions provider/ovh/ovh.go
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,15 @@ func (p *OVHProvider) record(zone *string, id uint64, records chan<- ovhRecord)

p.apiRateLimiter.Take()
if err := p.client.Get(fmt.Sprintf("/domain/zone/%s/record/%d", *zone, id), &record); err != nil {
var apiError *ovh.APIError
if errors.As(err, &apiError) {
// Maybe the ID disappeared in the mean time
// In that situation, we don't want to fail
// and we can silently ignore that record
if apiError.Code == 404 {
return nil
}
}
return err
}
if provider.SupportedRecordType(record.FieldType) {
Expand Down