GEP-1619: Add context on session persistence naming #2904
Conversation
k8s-ci-robot
added
release-note-none
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
kind/gep
There was a problem hiding this comment.
Thanks for adding all the extra context.
/ok-to-test
/cc @youngnick @robscott
geps/gep-1619/index.md
Outdated
| One concern for using the name "session persistence" is that it may confuse the idea of persisting a session to storage. | ||
| This confusion is particularly common among Java developers, as Java defines session persistence as storing a session to | ||
| disk. |
There was a problem hiding this comment.
| One concern for using the name "session persistence" is that it may confuse the idea of persisting a session to storage. | |
| This confusion is particularly common among Java developers, as Java defines session persistence as storing a session to | |
| disk. | |
| > **Note**: One concern for using the name "session persistence" is that it may confuse the idea of persisting a session to storage. | |
| > This confusion is particularly common among Java developers, as Java defines session persistence as storing a session to disk. |
k8s-ci-robot
added
ok-to-test
|
This is a great update, nice work @gcs278. Happy to LGTM as-is once it's move out of draft. |
geps/gep-1619/index.md
Outdated
| **Accepted definitions of "strong session affinity":** | ||
|
|
||
| - Session Persistence (preferred) | ||
| - Sticky Sessions |
There was a problem hiding this comment.
I'm not really sure it's helpful or useful to have multiple ways to refer to this concept in Gateway API. I think it may be useful to have docs that mention some common alternative names for what we refer to as "Session Persistence", but I'd rather just settle on one name for this concept within Gateway API and run with it.
There was a problem hiding this comment.
Yea that's a good point. Better to keep it simple with less options for folks to remember. Removed.
| and weak session affinity (what this GEP calls session affinity) which we will define further in [The Relationship of Session Persistence and Session Affinity](#the-relationship-of-session-persistence-and-session-affinity). | ||
| In this context, "strong" implies a guarantee, while "weak" indicates a best-effort approach. | ||
|
|
||
| Here's a survey of how some implementations refers to these ideas: |
There was a problem hiding this comment.
Nit: May want to include Envoy itself here, which uses "Stateful Session" terminology https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/stateful_session_filter
There was a problem hiding this comment.
Good point. But they also refer to it as "session stickiness". I'll put both.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gcs278, robscott, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Add a section "Naming" which outlines our decision for choosing session persistence and session affinity. Update section about session affinity to include the fact that session affinity CAN use cookies or headers. Also add details about the difference between persistence and affinity across proxy restarts or backend pool change.
gcs278
force-pushed
the
gep1619-naming-update
branch
from
0488561 to
43b93be
Compare
| and weak session affinity (what this GEP calls session affinity) which we will define further in [The Relationship of Session Persistence and Session Affinity](#the-relationship-of-session-persistence-and-session-affinity). | ||
| In this context, "strong" implies a guarantee, while "weak" indicates a best-effort approach. | ||
|
|
||
| Here's a survey of how some implementations refers to these ideas: |
There was a problem hiding this comment.
Good point. But they also refer to it as "session stickiness". I'll put both.
geps/gep-1619/index.md
Outdated
| **Accepted definitions of "strong session affinity":** | ||
|
|
||
| - Session Persistence (preferred) | ||
| - Sticky Sessions |
There was a problem hiding this comment.
Yea that's a good point. Better to keep it simple with less options for folks to remember. Removed.
geps/gep-1619/index.md
Outdated
| One concern for using the name "session persistence" is that it may confuse the idea of persisting a session to storage. | ||
| This confusion is particularly common among Java developers, as Java defines session persistence as storing a session to | ||
| disk. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
shaneutt
removed
the
do-not-merge/hold
What type of PR is this?
/kind gep
What this PR does / why we need it:
Add a section "Naming" which outlines our decision for choosing session persistence and session affinity. Also recognize sticky session as a valid alternative name.
Update section about session affinity to include the fact that session affinity CAN use cookies or headers. Also add details about the difference between persistence and affinity across proxy restarts or backend pool change.
Discussion: #2893
Which issue(s) this PR fixes:
Fixes #
Updates for #1619
Does this PR introduce a user-facing change?: