Setup goreleaser for gwctl to generate binaries for various platforms #3038

gauravkghildiyal · 2024-05-01T06:46:30Z

What type of PR is this?
/kind feature

What this PR does / why we need it:

Introduce gwctl version command to print binary information.

❯ gwctl version
Version: 1.0.0-SNAPSHOT-ca344b9a
Git Commit: ca344b9aa43ad5acc81235b25097fd20d8e97068
Build Date: 2024-05-01T06:29:53Z

Setup goreleaser to build binaries for various platforms

NOTES for the reviewer:

LICENSE file is added to the gwctl subdirectory so that it get's included in the archives generated by goreleaser.
Actual steps of how maintainers will make use of goreleaser to generate the binaries will be added independently (likely after some discussion)

Does this PR introduce a user-facing change?:

NONE

k8s-ci-robot · 2024-05-01T06:46:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauravkghildiyal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~gwctl/OWNERS~~ [gauravkghildiyal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

youngnick · 2024-05-06T07:02:42Z

gwctl/.goreleaser.yaml

+    - go mod tidy
+    - go build -o ./dist/gwctl ./main.go


At some point, both this and the repo CI should probably include a test suite. Much larger change, non-blocking for this one, but something to put on your todo.

Absolutely yes.

youngnick · 2024-05-06T07:02:58Z

/lgtm
/hold for further review though

gauravkghildiyal · 2024-05-08T04:20:31Z

/retest

pottekkat · 2024-05-10T04:29:56Z

gwctl/.goreleaser.yaml

+# For local testing, use:
+# 
+#   goreleaser release --snapshot --clean
+project_name: gwctl


Do we intend to keep gwctl as a standalone binary or as a kubectl plugin? If it is both, then wouldn't it be better to name the binary kubectl-*?

This PR only intended to make this available as a standalone binary, but you are right for kubectl plugin that is indeed a better name. (I'll attempt at addressing this in the new PR)

pottekkat · 2024-05-10T04:31:03Z

gwctl/cmd/root.go

+func newVersionCommand() *cobra.Command {
+	cmd := &cobra.Command{
+		Use:   "version",
+		Short: "Print the version information of gwctl",
+		Long:  `Print the version information of gwctl, including version, git commit and build date.`,
+		Run: func(*cobra.Command, []string) {
+			fmt.Println(version.GetVersionInfo())
+		},
+	}
+	return cmd
+}


nit: Shouldn't this be moved to a separate file like the rest of the subcommands?

Sure can! Thanks

k8s-ci-robot · 2024-05-17T11:33:40Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-triage-robot · 2024-07-21T16:22:49Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

mlavacca · 2024-08-19T17:09:09Z

I'll take a look into it

/cc

guicassolato · 2024-08-30T11:18:10Z

gwctl/.goreleaser.yaml

+      - -s -w 
+      # Embed versioning and build information in the binary.
+      - -X sigs.k8s.io/gateway-api/gwctl/pkg/version.version={{.Version}}
+      - -X sigs.k8s.io/gateway-api/gwctl/pkg/version.gitCommit={{.Commit}}


I think .Commit is deprecated. Should we use .FullCommit perhaps instead?

Suggested change

- -X sigs.k8s.io/gateway-api/gwctl/pkg/version.gitCommit={{.Commit}}

- -X sigs.k8s.io/gateway-api/gwctl/pkg/version.gitCommit={{.FullCommit}}

Ah thanks! Didn't know about the deprecation. Will update.

k8s-ci-robot · 2024-09-10T20:24:12Z

@gauravkghildiyal: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-gateway-api-crds-validation-1	`997fc07`	link	true	`/test pull-gateway-api-crds-validation-1`
pull-gateway-api-crds-validation-2	`997fc07`	link	true	`/test pull-gateway-api-crds-validation-2`
pull-gateway-api-crds-validation-4	`997fc07`	link	true	`/test pull-gateway-api-crds-validation-4`
pull-gateway-api-crds-validation-3	`997fc07`	link	true	`/test pull-gateway-api-crds-validation-3`
pull-gateway-api-crds-validation-5	`997fc07`	link	true	`/test pull-gateway-api-crds-validation-5`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

gauravkghildiyal · 2024-09-20T22:29:02Z

Thanks for the reviews here everyone! Closing this in favor of resolving this within https://github.com/kubernetes-sigs/gwctl.

/close

k8s-ci-robot · 2024-09-20T22:29:06Z

@gauravkghildiyal: Closed this PR.

In response to this:

Thanks for the reviews here everyone! Closing this in favor of resolving this within https://github.com/kubernetes-sigs/gwctl.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 1, 2024

k8s-ci-robot requested review from robscott and youngnick May 1, 2024 06:46

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/gwctl size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 1, 2024

gauravkghildiyal added 2 commits May 1, 2024 00:19

Setup command to print version information

0910e66

Setup goreleaser for gwctl

997fc07

gauravkghildiyal force-pushed the setup-releaser branch from f411b84 to 997fc07 Compare May 1, 2024 07:20

youngnick reviewed May 6, 2024

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2024

k8s-ci-robot assigned youngnick May 6, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2024

pottekkat reviewed May 10, 2024

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2024

shaneutt added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 21, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 21, 2024

k8s-ci-robot requested a review from mlavacca August 19, 2024 17:09

guicassolato reviewed Aug 30, 2024

View reviewed changes

k8s-ci-robot closed this Sep 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Setup goreleaser for gwctl to generate binaries for various platforms #3038

Setup goreleaser for gwctl to generate binaries for various platforms #3038

gauravkghildiyal commented May 1, 2024

k8s-ci-robot commented May 1, 2024

youngnick May 6, 2024

gauravkghildiyal May 6, 2024

youngnick commented May 6, 2024

gauravkghildiyal commented May 8, 2024

pottekkat May 10, 2024

gauravkghildiyal Sep 20, 2024

pottekkat May 10, 2024

gauravkghildiyal Sep 20, 2024

k8s-ci-robot commented May 17, 2024

k8s-triage-robot commented Jul 21, 2024

mlavacca commented Aug 19, 2024

guicassolato Aug 30, 2024

gauravkghildiyal Sep 20, 2024

k8s-ci-robot commented Sep 10, 2024

gauravkghildiyal commented Sep 20, 2024

k8s-ci-robot commented Sep 20, 2024

	- -X sigs.k8s.io/gateway-api/gwctl/pkg/version.gitCommit={{.Commit}}
	- -X sigs.k8s.io/gateway-api/gwctl/pkg/version.gitCommit={{.FullCommit}}

Setup goreleaser for gwctl to generate binaries for various platforms #3038

Setup goreleaser for gwctl to generate binaries for various platforms #3038

Conversation

gauravkghildiyal commented May 1, 2024

k8s-ci-robot commented May 1, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

youngnick commented May 6, 2024

gauravkghildiyal commented May 8, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k8s-ci-robot commented May 17, 2024

k8s-triage-robot commented Jul 21, 2024

mlavacca commented Aug 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k8s-ci-robot commented Sep 10, 2024

gauravkghildiyal commented Sep 20, 2024

k8s-ci-robot commented Sep 20, 2024