Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signal test stability #3313

Merged
merged 5 commits into from
Sep 11, 2024
Merged

Signal test stability #3313

merged 5 commits into from
Sep 11, 2024

Conversation

mlavacca
Copy link
Member

@mlavacca mlavacca commented Sep 3, 2024 •
edited
Loading

What type of PR is this?

/kind feature
/area conformance

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3009

Does this PR introduce a user-facing change?:

Conformance tests include a new Provisional field that signals the specific test's stability level. The conformance report has been updated to include which provisional tests have been successfully executed by the implementation.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. area/conformance labels Sep 3, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 3, 2024
@mlavacca mlavacca changed the title Signal test sability Signal test stability Sep 3, 2024
@mlavacca mlavacca force-pushed the test-stability branch 2 times, most recently from 604a9cd to a6f902b Compare September 4, 2024 13:48
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 4, 2024
@mlavacca mlavacca marked this pull request as ready for review September 4, 2024 13:51
@k8s-ci-robot k8s-ci-robot removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 4, 2024
@mlavacca
Copy link
Member Author

mlavacca commented Sep 4, 2024

/cc @robscott

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 4, 2024
@mlavacca
Copy link
Member Author

mlavacca commented Sep 4, 2024

/retest

@mlavacca mlavacca force-pushed the test-stability branch 2 times, most recently from 71da5a4 to 8e0ad7c Compare September 5, 2024 06:39
robscott
robscott approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mlavacca! A nit about naming but otherwise LGTM.

conformance/tests/udproute-simple.go Outdated Show resolved Hide resolved
@mlavacca mlavacca force-pushed the test-stability branch 2 times, most recently from 91d21c0 to 75fc418 Compare September 10, 2024 08:37
@mlavacca
feat: signal stability of tests
e72ec0a 
Signed-off-by: Mattia Lavacca <[email protected]>
robscott
robscott reviewed Sep 11, 2024
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mlavacca!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2024
shaneutt
shaneutt approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mlavacca, robscott, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5299919 into kubernetes-sigs:main Sep 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott robscott approved these changes

@youngnick youngnick youngnick left review comments

@shaneutt shaneutt shaneutt approved these changes

@candita candita Awaiting requested review from candita

@howardjohn howardjohn Awaiting requested review from howardjohn

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conformance: Signal Stability of Tests
5 participants
@mlavacca @k8s-ci-robot @robscott @shaneutt @youngnick