-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Exclude comments from CRD generation but not from go struct definition #3321
base: main
Are you sure you want to change the base?
feat: Exclude comments from CRD generation but not from go struct definition #3321
Conversation
Hi @Devaansh-Kumar. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
888aca4
to
48caedd
Compare
Thanks @Devaansh-Kumar! Do you mind adding an example of this in the PR to ensure it's working? Maybe write up a comment for #3306 (comment)? /ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Devaansh-Kumar, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Devaansh-Kumar as we discussed offline, mind also making it work for 1 line tags? like |
de71b43
to
2a869ef
Compare
What type of PR is this?
/kind documentation
/kind feature
What this PR does / why we need it:
This PR adds a new tag
gateway:util:excludeFromCRD
in CRD description which allows to exclude comments in the go struct from being included in the generated CRD, preventing unnecessary clutter in the CRD specification.Which issue(s) this PR fixes:
Fixes #3306
Does this PR introduce a user-facing change?:
/cc @LiorLieberman @robscott