Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Review for Release 1.2 #3328

Draft
wants to merge 1 commit into
base: release-1.1
Choose a base branch
from

Conversation

shaneutt
Copy link
Member

@shaneutt shaneutt commented Sep 10, 2024

API Review PR for 1.2 release

SEE THE CHANGELOG PR FIRST: #3327

This PR wont be merged directly, as its based against release-1.1 to specifically highlight the API changes since then.

Once we're done reviewing we'll simply close this without merging and the PR history will be for posterity, a release-1.2 branch will be pushed up based on main once we're ready to release (If we have any changes that come out of this PR review, they will be PR'd against main prior to release).

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2024
@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Sep 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/gep PRs related to Gateway Enhancement Proposal(GEP) size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 10, 2024
@shaneutt shaneutt force-pushed the shaneutt/release-1.2-api-review branch from ea1df1e to caf6d9d Compare September 10, 2024 14:02
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Sep 10, 2024
CHANGELOG/1.2-TEAM.md Outdated Show resolved Hide resolved
Signed-off-by: Shane Utt <[email protected]>
@shaneutt shaneutt force-pushed the shaneutt/release-1.2-api-review branch from caf6d9d to 0fb5571 Compare September 10, 2024 15:56
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 10, 2024
@shaneutt shaneutt changed the title Release 1.2 API Review Release 1.2 Sep 10, 2024
@shaneutt shaneutt changed the base branch from release-1.2 to release-1.1 September 10, 2024 20:26
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Sep 10, 2024
@shaneutt shaneutt changed the title Release 1.2 API Review for Release 1.2 Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/gwctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/gep PRs related to Gateway Enhancement Proposal(GEP) size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants