frontend: Remove multiplexer from useKubeObject function #4204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
approved
sniok
force-pushed
the
remove-multiplexer-from-details
branch
from
052f436 to
972f869
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sniok The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
removed
the
needs-rebase
Contributor
|
Can you make it not hard to enable again? |
sniok
force-pushed
the
remove-multiplexer-from-details
branch
from
972f869 to
4190e6b
Compare
k8s-ci-robot
added
size/XXL
joaquimrocha
requested changes
Nov 26, 2025
Comment on lines
+174
to
+194
| // Breaking rules of hooks here a little but | ||
| // getWebsocketMultiplexerEnabled is a feature toggle | ||
| // and not a variable so this `if` should never change during runtime | ||
| if (getWebsocketMultiplexerEnabled()) { | ||
| useWebSocket<KubeListUpdateEvent<K>>({ | ||
| url: () => | ||
| makeUrl([KubeObjectEndpoint.toUrl(endpoint!)], { | ||
| ...cleanedUpQueryParams, | ||
| watch: 1, | ||
| fieldSelector: `metadata.name=${name}`, | ||
| }), | ||
| enabled: !!endpoint && !!data, | ||
| cluster, | ||
| onMessage(update: KubeListUpdateEvent<K>) { | ||
| if (update.type !== 'ADDED' && update.object) { | ||
| client.setQueryData(queryKey, new kubeObjectClass(update.object)); | ||
| } | ||
| }, | ||
| }); | ||
| } else { | ||
| useWebSockets({ |
Contributor
There was a problem hiding this comment.
Doesn't this violate the no-conditional hooks rule?
Contributor
Author
There was a problem hiding this comment.
kind of but not really, I explained it in the comment. Think of it as a compile time 'if', it will never change during the runtime
sniok
force-pushed
the
remove-multiplexer-from-details
branch
from
4190e6b to
f0d5d10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that the details view still uses websocket multiplexer, which we disabled a while ago due to issues.
This PR reverts back to normal direct websocket connection,
Also moves multiplexer to a separate file so it's clearer (it was mixed with default websockets and probably that's why we forgot to disable it for the useKubeObject hook)