app: frontend: runCmd: Fixes for plugin types user and static #4212
+109
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This static-plugins path for plugins was added recently, but this function did not consider it.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: illume The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
k8s-ci-robot
added
the
do-not-merge/work-in-progress
This function was not updated to account for these two plugin type paths. Also the script exits with 1 when enountering a wrong path. Otherwise the script just hangs.
illume
force-pushed
the
run-cmd-plugin-folders
branch
from
e4e4446 to
837aa4a
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
illume
requested review from
Copilot and
joaquimrocha
and removed request for
ashu8912,
sniok and
yolossn
Copilot finished reviewing on behalf of
illume
November 26, 2025 21:23
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for static-plugins plugin type in both the frontend and backend (electron app), enabling plugins bundled with the application to be properly identified and executed alongside the existing plugins and user-plugins.
Key Changes:
- Extended path normalization and package identification to handle static-plugins directories
- Added static-plugins directory to the list of allowed script execution paths in the electron app
- Improved error handling in runScript to exit with code 1 instead of silently returning
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/src/plugin/runPlugin.ts | Added static-plugins path normalization and package identification mappings for minikube plugins |
| frontend/src/plugin/runPlugin.test.ts | Added comprehensive test coverage for static-plugins paths including Windows path handling |
| app/electron/runCmd.ts | Extended runScript validation to allow scripts from user-plugins and static-plugins directories, improved error handling |
| app/electron/runCmd.test.ts | Added test suite for runScript function covering all three allowed plugin directories |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the runCommand to properly take into account user and static plugins.
Testing
There are some unit tests for this that are run on win/linux/Mac.
The minikube plugin was failing by hanging on the Add cluster view when installed as a user plugin.