Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix make apply #1932

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

carlory
Copy link
Member

@carlory carlory commented Jan 26, 2025

Description

Can not get the right image digest when applying this guide: https://github.com/kubernetes-sigs/karpenter/tree/main/kwok

(base) ➜  karpenter git:(main) ✗ export KIND_CLUSTER_NAME=kind
(base) ➜  karpenter git:(main) ✗ KO_DOCKER_REPO="kind.local"
(base) ➜  karpenter git:(main) ✗ make apply
...
helm upgrade --install karpenter kwok/charts --namespace kube-system --skip-crds \
		--set logLevel=debug --set controller.resources.requests.cpu=1 --set controller.resources.requests.memory=1Gi --set controller.resources.limits.cpu=1 --set controller.resources.limits.memory=1Gi \
		--set controller.image.repository=kind.local/kwok \
		--set controller.image.tag=e01ee363f7007f73a4966469b6a5e7dfac32350c97bfab0085c2af648c529153 \
		--set controller.image.digest=kind.local/kwok:e01ee363f7007f73a4966469b6a5e7dfac32350c97bfab0085c2af648c529153 \
...
(base) ➜  karpenter git:(main) ✗ kubectl get  po -n kube-system karpenter-6496969887-hw2hj
NAME                         READY   STATUS             RESTARTS   AGE
karpenter-6496969887-hw2hj   0/1     InvalidImageName   0          73s
(base) ➜  karpenter git:(main) ✗ kubectl get po -n kube-system karpenter-6496969887-hw2hj -oyaml | grep image
    image: kind.local/kwok:e01ee363f7007f73a4966469b6a5e7dfac32350c97bfab0085c2af648c529153@kind.local/kwok:e01ee363f7007f73a4966469b6a5e7dfac32350c97bfab0085c2af648c529153
...

/hold
for ko-build/ko#1475

How was this change tested?

(base) ➜  karpenter git:(main) ✗ export KIND_CLUSTER_NAME=kind
(base) ➜  karpenter git:(main) ✗ KO_DOCKER_REPO="kind.local"
(base) ➜  karpenter git:(main) ✗ make apply
...
helm upgrade --install karpenter kwok/charts --namespace kube-system --skip-crds \
		--set logLevel=debug --set controller.resources.requests.cpu=1 --set controller.resources.requests.memory=1Gi --set controller.resources.limits.cpu=1 --set controller.resources.limits.memory=1Gi \
		--set controller.image.repository=kind.local/kwok \
		--set controller.image.tag=e01ee363f7007f73a4966469b6a5e7dfac32350c97bfab0085c2af648c529153 \
		--set controller.image.digest= \
...
(base) ➜  karpenter git:(main) ✗ kubectl get po -A
NAMESPACE            NAME                                         READY   STATUS    RESTARTS       AGE
kube-system          coredns-668d6bf9bc-6mws9                     1/1     Running   3 (4d4h ago)   10d
kube-system          coredns-668d6bf9bc-9bhxr                     1/1     Running   3 (4d4h ago)   10d
kube-system          etcd-kind-control-plane                      1/1     Running   0              4d4h
kube-system          karpenter-74995c6d54-lgbd4                   1/1     Running   0              16s
kube-system          kindnet-ggv2b                                1/1     Running   3 (4d4h ago)   10d
kube-system          kube-apiserver-kind-control-plane            1/1     Running   0              4d4h
kube-system          kube-controller-manager-kind-control-plane   1/1     Running   3 (4d4h ago)   10d
kube-system          kube-proxy-bpcn7                             1/1     Running   3 (4d4h ago)   10d
kube-system          kube-scheduler-kind-control-plane            1/1     Running   3 (4d4h ago)   10d
kube-system          kwok-controller-a-788697bc98-2p2bm           1/1     Running   6 (4d4h ago)   10d
local-path-storage   local-path-provisioner-58cc7856b6-d4k9k      1/1     Running   6 (4d4h ago)   10d

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: carlory
Once this PR has been reviewed and has the lgtm label, please assign bwagner5 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 26, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12973855416

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 81.239%

Totals Coverage Status
Change from base Build 12954850842: 0.1%
Covered Lines: 9089
Relevant Lines: 11188

💛 - Coveralls

@jonathan-innis
Copy link
Member

Yeah, I think you had this right that this definitely looks like a bug with ko that's causing this, but let's wait to hear back from them on that issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants