-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create Unhealthy Disrupted Nodeclaim Metric #1952
feat: Create Unhealthy Disrupted Nodeclaim Metric #1952
Conversation
6e2a300
to
0807820
Compare
0807820
to
455edc8
Compare
Pull Request Test Coverage Report for Build 13130382009Details
💛 - Coveralls |
455edc8
to
e7406c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good -- I'd just match the disrupted reason label with the naming of the disrupted metric
ebaf0cc
to
8b03d5e
Compare
79922ec
to
b0a2a2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: engedaam, jonathan-innis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #N/A
Description
Add dedicated metrics for tracking unhealthy disrupted nodeclaims
This PR introduces a new of metric specifically for tracking nodeclaims that were disrupted due to unhealthy states, separate from other disruption types. This separation enables:
This change improves observability by distinguishing between health-related node disruptions and other forms of disruption
How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.