Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create Unhealthy Disrupted Nodeclaim Metric #1952

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Feb 1, 2025

Fixes #N/A

Description
Add dedicated metrics for tracking unhealthy disrupted nodeclaims

This PR introduces a new of metric specifically for tracking nodeclaims that were disrupted due to unhealthy states, separate from other disruption types. This separation enables:

  • More precise monitoring of repair-related disruptions
  • Better alerting capabilities for node health issues
  • Distinct label sets optimized for repaired node scenarios

This change improves observability by distinguishing between health-related node disruptions and other forms of disruption

How was this change tested?

  • make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 1, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 1, 2025
@engedaam engedaam changed the title chore: Create unhealthy disrupted nodeclaim metric feat: Create unhealthy disrupted nodeclaim metric Feb 1, 2025
@engedaam engedaam changed the title feat: Create unhealthy disrupted nodeclaim metric feat: Create Unhealthy Disrupted Nodeclaim Metric Feb 1, 2025
@engedaam engedaam force-pushed the create-seprate-metrics-for-unhealthy-nodes branch from 6e2a300 to 0807820 Compare February 1, 2025 01:03
@engedaam engedaam force-pushed the create-seprate-metrics-for-unhealthy-nodes branch from 0807820 to 455edc8 Compare February 1, 2025 01:13
@coveralls
Copy link

coveralls commented Feb 1, 2025

Pull Request Test Coverage Report for Build 13130382009

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 81.228%

Files with Coverage Reduction New Missed Lines %
pkg/test/expectations/expectations.go 2 94.81%
pkg/controllers/disruption/consolidation.go 4 88.55%
Totals Coverage Status
Change from base Build 13127485405: -0.03%
Covered Lines: 9100
Relevant Lines: 11203

💛 - Coveralls

@engedaam engedaam force-pushed the create-seprate-metrics-for-unhealthy-nodes branch from 455edc8 to e7406c7 Compare February 1, 2025 01:27
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- I'd just match the disrupted reason label with the naming of the disrupted metric

pkg/metrics/constants.go Outdated Show resolved Hide resolved
@engedaam engedaam force-pushed the create-seprate-metrics-for-unhealthy-nodes branch from ebaf0cc to 8b03d5e Compare February 3, 2025 17:02
@engedaam engedaam force-pushed the create-seprate-metrics-for-unhealthy-nodes branch from 79922ec to b0a2a2e Compare February 4, 2025 07:26
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: engedaam, jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2025
@k8s-ci-robot k8s-ci-robot merged commit a2697c2 into kubernetes-sigs:main Feb 4, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants