-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to tidy up documentation #3869
base: main
Are you sure you want to change the base?
Conversation
This tries to fix up the hanging sentance
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: adrianmoisey The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @adrianmoisey! |
Hi @adrianmoisey. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -102,7 +102,7 @@ Multiple details of the cluster's networking can be customized under the | |||
|
|||
#### IP Family | |||
|
|||
KIND has support for IPv4, IPv6 and dual-stack clusters, you can switch from the default of IPv4 by setting: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This "you can switch from the default of IPv4 by setting:" felt strange. When I read it it felt like a config option was missing after the colon, but I see everything is described in the text below.
This attempts to fix that problem, but It feels un-elegant to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need english native people, @BenTheElder , we still need to mention that the default is IPv4 in the new sentence
/ok-to-test |
This reads better to me. It's possible the original text has evolved where it made sense to have the /lgtm |
Co-authored-by: Antonio Ojea <[email protected]>
/lgtm Thanks! |
This tries to fix up the hanging sentance