-
Notifications
You must be signed in to change notification settings - Fork 1.6k
🐛 fix(cli): version subcommand pretty output #5236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
🐛 fix(cli): version subcommand pretty output #5236
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vitorfloriano The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @vitorfloriano. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5d77665 to
ae97bbf
Compare
|
Hi @camilamacedo86 could you help me out on this one? I was trying to not be so disruptive about this change by using a Also, I saw that a previous PR (#4898) also tried to add One more thing: I checked that the version field is correctly being recorded in the PROJECT file. I ran Then in a project I initialized for testing I checked that the cliVersion field is still there: PTAL 🙏🏻 |
WIP: This PR tries to make the
kubebuilder versionoutput a little more human-readable with as little disruption as possible.