Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Cilium Helm Chart deployment #11430

Closed

Conversation

HoKim98
Copy link
Contributor

@HoKim98 HoKim98 commented Aug 8, 2024

PR Type

/kind feature

What this PR Does / Why We Need It

  • Adds support for kube_network_plugin: "cilium-helm"
  • Enables the deployment of Cilium CNI using their official Helm Chart

Which Issue(s) this PR Fixes

Potentially fixes #10938, #11047, #11110

Special Notes for Your Reviewer

Following the presentation at KubeCon 2023, Cilium has expanded significantly, showcasing various features and technical integrations. As of version 1.16.0, Cilium maintains an extensive Helm values file encompassing 3524 lines. This large-scale project, unfortunately, poses a challenge for swift integration into community-driven projects like Kubespray. Therefore, I propose enabling the deployment of Cilium CNI using their official Helm Chart, allowing Kubespray to focus solely on compatibility. This approach aims to ease the burden on community contributors by eliminating the need to meticulously track Cilium's development trends.

Although Cilium CNI can currently be installed via custom_cni, this method does not leverage Kubespray functionalities such as reset or kube_* variables.

This PR supports the installation of Cilium CNI. However, deployment in offline environments is not yet supported and remains an outstanding task.

Does this PR Introduce a User-Facing Change?

No, this new deployment method is activated only when kube_network_plugin == "cilium-helm".

Add support for Cilium Helm Chart deployment on `kube_network_plugin: "cilium-helm"`

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: HoKim98
Once this PR has been reviewed and has the lgtm label, please assign oomichi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 8, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @HoKim98. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@HoKim98 HoKim98 marked this pull request as ready for review August 8, 2024 04:08
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 8, 2024
@tico88612
Copy link
Member

@HoKim98 Thanks for starting this PR discussion, but unfortunately, in my experience, custom_cni actually does this. (I don't see the need for a new cilium-helm option, unless there's something different about it.)

@MrFreezeex
Copy link
Member

MrFreezeex commented Aug 8, 2024

@HoKim98 Thanks for starting this PR discussion, but unfortunately, in my experience, custom_cni actually does this. (I don't see the need for a new cilium-helm option, unless there's something different about it.)

Maybe we should deprecate or at least encourage switching to custom_cni in the Cilium case as we had a long history of lagging behind Cilium deployment changes.

@tico88612
Copy link
Member

Another idea I had was that you could write examples to documentation, and I think many beginners would be confused when they see custom_cni.

@HoKim98
Copy link
Contributor Author

HoKim98 commented Aug 8, 2024

I completely agree! Along with PR #11432, I will address the issue by creating a manual for users who utilize custom_cni (especially Cilium). I will deploy it with some challenging configurations on the research and development cluster I manage. If I determine there are no more painful issues, I will attempt to compile it into a manual! Closing the PR.

@HoKim98 HoKim98 closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow disabling cilium hubble-ui
4 participants