Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Policy Assistant] display enhancements from KubeCon demo (PR 1/2) #241

Merged
merged 4 commits into from
Jul 22, 2024

Conversation

huntergregory
Copy link
Contributor

A few enhancements:

  1. display (b)anp rule names in the table and "Flow"
  2. make connectivity table easier to read for loopback traffic
  3. stop adding an extra row in the explain table when there are no egress policy rules

New flow example:

[NPv1] Allow (rule-name)

Loopback traffic example (adding "#")

simulated connectivity:
+--------+--------+--------+
| TCP/80 | DEMO/A | DEMO/B |
| TCP/81 |        |        |
+--------+--------+--------+
| demo/a | # X    | . X    |
+--------+--------+--------+
| demo/b | . X    | # X    |
+--------+--------+--------+

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huntergregory

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 19, 2024
Copy link

netlify bot commented Jul 19, 2024

Deploy Preview for kubernetes-sigs-network-policy-api ready!

Name Link
🔨 Latest commit ec80379
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-network-policy-api/deploys/6699db253e807c0008de48f6
😎 Deploy Preview https://deploy-preview-241--kubernetes-sigs-network-policy-api.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@huntergregory huntergregory changed the title [Policy Assistant] display enhancements [Policy Assistant] display enhancements from KubeCon (PR 1/2) Jul 19, 2024
@huntergregory huntergregory changed the title [Policy Assistant] display enhancements from KubeCon (PR 1/2) [Policy Assistant] display enhancements from KubeCon demo (PR 1/2) Jul 19, 2024
@mattfenwick
Copy link
Contributor

I like this -- making those undefined cases explicit!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit f4558c8 into kubernetes-sigs:main Jul 22, 2024
10 checks passed
huntergregory added a commit to huntergregory/network-policy-api that referenced this pull request Jul 22, 2024
k8s-ci-robot added a commit that referenced this pull request Jul 23, 2024
[Policy Assistant] fix: compile error introduced by #241
huntergregory added a commit to huntergregory/network-policy-api that referenced this pull request Aug 8, 2024
huntergregory added a commit to huntergregory/network-policy-api that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants