-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [Policy Assistant] walkthrough mode and a README (KubeCon demo PR 2/2) #245
Conversation
✅ Deploy Preview for kubernetes-sigs-network-policy-api ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
9668f6a
to
9db719b
Compare
Signed-off-by: Hunter Gregory <[email protected]>
Signed-off-by: Hunter Gregory <[email protected]>
Signed-off-by: Hunter Gregory <[email protected]>
Signed-off-by: Hunter Gregory <[email protected]>
9db719b
to
0969ff4
Compare
0969ff4
to
d0c2abb
Compare
Signed-off-by: Hunter Gregory <[email protected]>
Signed-off-by: Hunter Gregory <[email protected]>
d0c2abb
to
ba3b224
Compare
ba3b224
to
4921bbb
Compare
/lgtm |
@huntergregory: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Tests are passing via policy-assistant GH action. These commands work locally:
Want to add these to the GH action once we add walkthrough traffic support in a followup. |
Hey @mattfenwick do you mind adding a lgtm? Thinking to iterate quickly on a few more PRs and cut the first release by ~11/5 for a KubeCon announcement 🎉 Release details: #255 |
Signed-off-by: Hunter Gregory <[email protected]>
Hey @danwinship could you approve the GH action change and add a lgtm? Thanks! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, huntergregory The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
--mode strings analysis modes to run; allowed values are explain,probe,walkthrough (default [explain])
Outputs
walkthrough
Fixes #168. NOTE: the traffic is hardcoded right now. Need to fix in a followup PR that leverages #227 to specify traffic for the walkthrough.
probe
Fixes #210