Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inject build information during tool installation #440

Merged
merged 2 commits into from
Oct 5, 2021
Merged

Inject build information during tool installation #440

merged 2 commits into from
Oct 5, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Oct 1, 2021 •
edited by justaugustus
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Inject build information during tool installation

the local build

$ docker run ba7873ce9e60 version
GitVersion:    v3.3.0-beta.0-1-g5a4c142-dirty
GitCommit:     5a4c142b979c7a4b9d359c1f05ed7250a83fc7a3
GitTreeState:  dirty
BuildDate:     '2021-10-04T14:21:25Z'
GoVersion:     go1.17.1
Compiler:      gc
Platform:      linux/amd64

/assign @justaugustus @puerco
cc @kubernetes-sigs/release-engineering

Which issue(s) this PR fixes:

Fixes: #436

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Inject build information during tool installation

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 1, 2021
@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 1, 2021
justaugustus
justaugustus requested changes Oct 2, 2021
View reviewed changes
Copy link
Contributor

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpanato -- Looks great so far!
While we're here, let's pull the version command up a level (since the version is true for all subcommands) i.e.,

kpromo version

/retitle Inject build information during tool installation

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot changed the title cip-mm: inject build information during the image bake Inject build information during tool installation Oct 2, 2021
@justaugustus
Copy link
Contributor

Also:
/hold for #437

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 2, 2021
@cpanato cpanato requested a review from justaugustus October 4, 2021 14:45
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 4, 2021
@cpanato
Copy link
Member Author

cpanato commented Oct 4, 2021 

$ docker run ba7873ce9e60 version
GitVersion:    v3.3.0-beta.0-1-g5a4c142-dirty
GitCommit:     5a4c142b979c7a4b9d359c1f05ed7250a83fc7a3
GitTreeState:  dirty
BuildDate:     '2021-10-04T14:21:25Z'
GoVersion:     go1.17.1
Compiler:      gc
Platform:      linux/amd64

justaugustus
justaugustus approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cpanato!
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,justaugustus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e2b918e into kubernetes-sigs:main Oct 5, 2021
@cpanato cpanato deleted the GH-436 branch October 5, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus approved these changes

@jimangel jimangel Awaiting requested review from jimangel

@mkorbi mkorbi Awaiting requested review from mkorbi

Assignees

@justaugustus justaugustus

@puerco puerco

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kpromo cip version should actually provide build info in container
4 participants
@cpanato @justaugustus @k8s-ci-robot @puerco