Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable MatchInterPodAffinity if there are no pods using affinity #281

Merged
merged 1 commit into from
Aug 31, 2017

Conversation

MaciekPytel
Copy link
Contributor

Ref: #257

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 30, 2017
@MaciekPytel MaciekPytel requested a review from mwielgus August 30, 2017 14:29
@MaciekPytel MaciekPytel added this to the CA-0.7 milestone Aug 30, 2017
@MaciekPytel MaciekPytel changed the title WIP: Disable MatchInterPodAffinity if there are no pods using affinity Disable MatchInterPodAffinity if there are no pods using affinity Aug 31, 2017
@MaciekPytel
Copy link
Contributor Author

I did some basic manual sanity test to confirm that the predicate is switched back on when I create a pod using antiaffinity and disabled once I delete this pod.

In performance test it reduced maximum findUnneded time to <2.5s bucket (we don't log exact length if it's below 5s), with average duration dropping to <0.4s.

@mwielgus
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2017
@mwielgus mwielgus merged commit 7c1aa11 into kubernetes:master Aug 31, 2017
jkyros pushed a commit to jkyros/autoscaler that referenced this pull request Jan 24, 2024
OCPBUGS-27509: Fix unstructured taint parsing in Cluster API provider
yaroslava-serdiuk pushed a commit to yaroslava-serdiuk/autoscaler that referenced this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants