fix(hetzner): deprecated server type will break on 2024-09-06 #7211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind cleanup
What this PR does / why we need it:
The
cx11
server type was deprecated on 2024-06-06 and will be removed from the API on 2024-09-06. Once it is removed, the cluster-autoscaler provider hetzner will fail every main loop with with the following error messages:The server type is hardcoded in the
draining-node-pool
, which was used in the OG PR #3640 but unused in the second PR #3838 that was actually merged.As the
draining-node-pool
is unused since the first release of this provider, I have opted to remove it altogether. In theory this is a user visible change, as this node pool is visible through the status config mapWhich issue(s) this PR fixes:
Fixes #7210
Special notes for your reviewer:
We would like to back port this change to all actives releases ASAP. If you think this change does not qualify for a back port, I am happy to submit a different PR that only changes the hardcoded server type to one that will be available for longer.
This one is one me. I should have noticed this reference when checking our projects for hardcoded
cx11
references when the deprecation was announced.Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: