-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add test-build-tags make target #7391
add test-build-tags make target #7391
Conversation
/assign @MaciekPytel |
cluster-autoscaler/Makefile
Outdated
@@ -9,6 +9,7 @@ GOOS?=linux | |||
GOARCH?=$(shell go env GOARCH) | |||
REGISTRY?=staging-k8s.gcr.io | |||
DOCKER_NETWORK?=default | |||
SUPPORTED_BUILD_TAGS=gce aws azure kubemark alicloud magnum digitalocean clusterapi huaweicloud ionoscloud linode hetzner bizflycloud brightbox equinixmetal oci vultr tencentcloud scaleway externalgrpc civo rancher volcengine baiducloud cherry cloudstack exoscale kamatera ovhcloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we could have a single source of truth for this. I thought something like:
ls cluster-autoscaler/cloudprovider/builder/ | grep -e '^builder_.*\.go' | sed 's/builder_\(.*\)\.go/\1/'
Though the downside is if the list becomes empty, the test will keep on passing. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I incorporated this improvement and ensured that there are the right error paths as well, ptal. Thanks!
Signed-off-by: Jack Francis <[email protected]>
fe8be3d
to
f1a1bab
Compare
/assign @BigDarkClown @feiskyer I think this and then kubernetes/test-infra#33656 would ensure that our build tags remain hygienic cc @voelzmo |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, x13n The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR adds a
test-build-tags
make target to enable us to easily validate the functionality of provider-specific build tags.While doing this I cleaned up several issues, including some that were preventing a few providers from even compiling w/ their build tags. :/
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: