feat: implement force delete for the azure provider #7687
+13
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bryce-Soghigian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/provider/azure
tallaxes
reviewed
Jan 9, 2025
comtalyst
reviewed
Jan 16, 2025
| @@ -613,28 +615,12 @@ func (scaleSet *ScaleSet) DeleteNodes(nodes []*apiv1.Node) error { | |||
| ref := &azureRef{ | |||
| Name: node.Spec.ProviderID, | |||
| } | |||
|
|
|||
| if node.Annotations[cloudprovider.FakeNodeReasonAnnotation] == cloudprovider.FakeNodeUnregistered { | |||
There was a problem hiding this comment.
What's the motivation/expectation of this change?
There was a problem hiding this comment.
To clean up long unregistered nodes
There was a problem hiding this comment.
Is that not the case before? I'm seeing it being deleted by return scaleSet.DeleteInstances(unregisteredRefs, true).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Introduces the force delete implementation for azure to help clean up long unregistered nodes.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: