Fix data race while setting delta cluster state in parallel #7696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
|
/cc @x13n |
k8s-ci-robot
added
the
size/M
x13n
requested changes
Jan 15, 2025
macsko
force-pushed
the
fix_data_race_while_setting_delta_cluster_state_in_parallel
branch
from
51a805c to
b36e387
Compare
That's right. I didn't notice the |
|
/lgtm |
k8s-ci-robot
added
lgtm
x13n
approved these changes
Jan 15, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: macsko, x13n The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Clearing caches while adding a pod was causing data race. This step is redundant when setting cluster state, as cache is empty anyway.
Which issue(s) this PR fixes:
See #7695
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: