Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the go version to v1.23.2 for the GitHub workflows. #7725

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Shubham82
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Bump the go version under GitHub workflow to 1.23.2, as Dockerfile and go.mod uses go version 1.23.2

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 20, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Shubham82
Once this PR has been reviewed and has the lgtm label, please assign mwielgus for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 20, 2025
@Shubham82
Copy link
Contributor Author

Hi @gjtempleton @MaciekPytel
PTAL!

@@ -17,7 +17,7 @@ jobs:
- name: Set up Go
uses: actions/[email protected]
with:
go-version: '1.22.2'
go-version: '1.23.2'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to not use 1.23.5 ?
Also, does this action need to install a specific version? What if it just installed latest?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I read the PR description and see the reason for this version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrianmoisey, to make the go version f.or ci pipeline for GitHub workflow use the same version as we used for our projects

@gjtempleton
Copy link
Member

Question for a future improvement: Worth scripting something up to keep these versions in sync whenever we touch one of them? (Potentially an extension to the existing update-deps.sh?)

We also have one CI pipeline for all the projects under this repo, current drift at the head of the default branch is only one patch release, but we could be drifting further in the future - any risks here?

@Shubham82
Copy link
Contributor Author

Question for a future improvement: Worth scripting something up to keep these versions in sync whenever we touch one of them? (Potentially an extension to the existing update-deps.sh?)

@gjtempleton, That sounds good. We can script this part so that the go version under ci.yaml will also be updated when we update other dependencies.

We also have one CI pipeline for all the projects under this repo, current drift at the head of the default branch is only one patch release, but we could be drifting further in the future - any risks here?

IMO, there is no risk, as projects used the go version corresponding to the latest k8s version.

VPA: https://github.com/kubernetes/autoscaler/blob/master/vertical-pod-autoscaler/go.mod

@gjtempleton your thoughts?

@adrianmoisey
Copy link
Member

We also have one CI pipeline for all the projects under this repo, current drift at the head of the default branch is only one patch release, but we could be drifting further in the future - any risks here?

IMO, there is no risk, as projects used the go version corresponding to the latest k8s version.

Is this a requirement? Is there value in the projects in this repo matching the k/k go version?

@Shubham82
Copy link
Contributor Author

We also have one CI pipeline for all the projects under this repo, current drift at the head of the default branch is only one patch release, but we could be drifting further in the future - any risks here?

IMO, there is no risk, as projects used the go version corresponding to the latest k8s version.

Is this a requirement? Is there value in the projects in this repo matching the k/k go version?

Talking about CA, For every CA release, we update the corresponding upstream dependencies(k8s), so CA version and Kubernetes version have a one-to-one correspondence.
I think it is with VPA also, There was some talk of improvement in this area in vpa (#5759)

@adrianmoisey
Copy link
Member

Talking about CA, For every CA release, we update the corresponding upstream dependencies(k8s), so CA version and Kubernetes version have a one-to-one correspondence.

What is the reason for this? Is there a need to have a one-to-one correspondence?

@Shubham82
Copy link
Contributor Author

Hi @adrianmoisey
CA imports a huge chunk of internal k8s code because it calls out to the scheduler implementation. Therefore, to avoid version incompatibilities we keep the set of libraries used in CA as used by k8s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants