DigitalOcean: Implement TemplateNodeInfo in DO cloud provider CA to support scaling up from zero

[dylanrhysscott]

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR updates the DigitalOcean cloud provider implementation to support the TemplateNodeInfo() method which can be utilised by cluster autoscaler to scale up node groups from zero

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: dylanrhysscott / name: Dylan Scott (8c036c9, 385a427)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dylanrhysscott
Once this PR has been reviewed and has the lgtm label, please assign x13n for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• cluster-autoscaler/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @dylanrhysscott!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @dylanrhysscott. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[gottwald]

/ok-to-test

[dylanrhysscott]

Tested GPU scale up from zero with new taints in template and everything now works correctly - have pushed the code change but am waiting on a new godo version release to finalise this PR

[gottwald]

This looks a bit inconsistent. This should rather be a KubernetesNodePoolTemplate instead of the rpc response type.

[gottwald]

I can't quite follow the logic of this. The worker ID seems to be intended to be something dynamic.
However the only call I can find is for the worker ID to be 1.
If you just want to create a random fixed size string suffix from a defined charset, you could follow something like this https://www.calhoun.io/creating-random-strings-in-go/