Support CPU Startup Boost in VPA #7863
Conversation
k8s-ci-robot
added
kind/documentation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: laoj2 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
|
Hi @laoj2. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/L
|
/assign @raywainman cc @jpawelczak |
| ### Goals | ||
|
|
||
| * Allow VPA to boost the CPU request and limit of a pod's containers when the pod during the pod startup (from creation time until it becomes `Ready`.) | ||
| * Allow VPA to scale pods down to the original CPU resource values, [in-place](https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/1287-in-place-update-pod-resources), as soon as their [`Ready`](https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-conditions) condition is true. |
There was a problem hiding this comment.
I assume "original CPU resource values" should actually be whatever the value the VPA recommender has set as a recommendation?
Or is the idea to scale back to what was defined in the Pod spec?
|
|
||
| ## Proposal | ||
|
|
||
| To extend [`ContainerResourcePolicy`](https://github.com/kubernetes/autoscaler/blob/0a34bf5d3a71b486bdaa440f1af7f8d50dc8e391/vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1/types.go#L190) with a `StartupBoost.CPU.Factor` field, that will instruct VPA the factor by which to multiply the initial resource request and limit of the containers' targeted by the VPA object. |
There was a problem hiding this comment.
Should the CPU factor be applied to the initial resource request and limit of the container, or on the VPA recommenders recommendation? (this is similar to my previous comment)
What type of PR is this?
/kind documentation
/kind feature
What this PR does / why we need it:
Autoscaling Enhancement Proposal to add basic support for boosting CPU of workloads in VPA, leveraging in-place pod resizes.
Would love your thoughts on this feature. This can be a great addition on top of AEP-4016
#7862