Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AEP-4016: remove mention of 'partial updates' in testing plan #7896

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maxcao13
Copy link
Member

@maxcao13 maxcao13 commented Mar 6, 2025

What type of PR is this?

/kind documentation
/kind cleanup

What this PR does / why we need it:

Removes mention of "partial updates" from the AEP-4016 testing plan.

This is because, VPA accepts whole pods for updates if at least 1 container is considered "out of recommendation bounds", it doesn't care about which one(s). If at least one container is out of bounds, the updater will try to in-place resize the entire pod and update all containers with the most current recs. We shouldn't need to introduce new logic to apply resizes only to the containers that actually have recommendations out of bounds.

Which issue(s) this PR fixes:

Fixes #

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [AEP]: https://github.com/kubernetes/autoscaler/tree/master/vertical-pod-autoscaler/enhancements/4016-in-place-updates-support

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 6, 2025
@k8s-ci-robot k8s-ci-robot requested a review from raywainman March 6, 2025 17:38
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 6, 2025
Copy link
Member

@omerap12 omerap12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2025
@raywainman
Copy link
Contributor

/lgtm

/assign @voelzmo

@adrianmoisey
Copy link
Member

/lgtm

@@ -229,8 +229,6 @@ tested in the following scenarios:

* Admission controller applies recommendation to pod controlled by VPA.
* In-place update applied to all containers of a pod.
* Partial updates applied to some containers of a pod, some changes skipped (request in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we still mention this point somewhere in this AEP? Maybe in "Details still to consider" section? So this doesn't get lost. It'll be great to implement partial updates at some point :)

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maxcao13, omerap12
Once this PR has been reviewed and has the lgtm label, please ask for approval from raywainman. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 7, 2025
@adrianmoisey
Copy link
Member

/lgtm

Good call out on retaining the info, rather than deleting it

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2025
@omerap12
Copy link
Member

omerap12 commented Mar 8, 2025

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants