[AKS VMs Pool] Add VMs implementation to master #8078
Conversation
k8s-ci-robot
added
kind/feature
|
Hi @wenxuan0923. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
needs-ok-to-test
k8s-ci-robot
added
the
size/XXL
| "github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2022-08-01/compute" | ||
| "github.com/Azure/go-autorest/autorest/to" | ||
|
|
||
| apiv1 "k8s.io/api/core/v1" | ||
| "k8s.io/autoscaler/cluster-autoscaler/cloudprovider" | ||
| "k8s.io/autoscaler/cluster-autoscaler/config" | ||
| "k8s.io/autoscaler/cluster-autoscaler/config/dynamic" | ||
| "k8s.io/autoscaler/cluster-autoscaler/simulator/framework" |
There was a problem hiding this comment.
There are diffs here from 1.30. Could you fix it?
There was a problem hiding this comment.
The diff comes from the switch from "k8s.io/kubernetes/pkg/scheduler/framework" to "k8s.io/autoscaler/cluster-autoscaler/simulator/framework" since 1.32
| return nil, err | ||
| } | ||
|
|
||
| nodeInfo := framework.NewNodeInfo(node, nil, &framework.PodInfo{Pod: cloudprovider.BuildKubeProxy(vmPool.agentPoolName)}) |
There was a problem hiding this comment.
FYI this will be an inevitable diff between > and >= 1.32. Thus cherry-picking this to 1.30 and 1.31 won't work. Given you already have 1.30 branch, maybe cherry-pick that one to 1.31, and cherry-pick this one to 1.32.
|
/lgtm |
k8s-ci-robot
added
the
tide/merge-method-squash
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: comtalyst, wenxuan0923 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @jackfrancis another go.mod changes here, thanks! |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
Add VMs implementation to master
/kind feature
What this PR does / why we need it:
Support AKS VMs pool autoscaling
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: