feat: CPU startup boost in master #8813

kamarabbas99 · 2025-11-13T20:22:47Z

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

The CPU startup boost chnges were done on experimental branch, moving this to master.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Users can configure a startupBoost policy in the VPA spec.

Which issue(s) this PR fixes:

#7862

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: (https://github.com/kubernetes/autoscaler/tree/master/vertical-pod-autoscaler/enhancements/7862-cpu-startup-boost#aep-7862-cpu-startup-boost)

Fix VPA startup boost validation error messages

Fix test failure after rebase

Add e2e tests for CPU startup boost

kamarabbas99 · 2025-11-13T20:23:39Z

/cc adrianmoisey omerap12

k8s-triage-robot · 2025-11-13T20:43:09Z

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

omerap12

Nice! we already approved this in previous PRs 🥳
/lgtm
/label tide/merge-method-squash

vertical-pod-autoscaler/docs/features.md

omerap12 · 2025-11-14T06:52:21Z

oh good catch
/lgtm cancel

adrianmoisey · 2025-11-14T06:56:45Z

/cc @soltysh
Do you mind doing API review on this?
It was previously reviewed over in #8417, when it was merged into a feature branch.
But now that we're merging it into master, I assume it needs re-review?

Update VPA version for startupboost feature

adrianmoisey · 2025-11-16T13:20:25Z

I'm good with this, thanks for doing it!
/lgtm

omerap12 · 2025-11-16T17:45:02Z

/approve

k8s-ci-robot · 2025-11-16T17:45:12Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kamarabbas99, omerap12
Once this PR has been reviewed and has the lgtm label, please assign liggitt for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

~~vertical-pod-autoscaler/OWNERS~~ [omerap12]
vertical-pod-autoscaler/pkg/apis/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

soltysh · 2025-11-19T10:25:28Z

/label api-review

soltysh

I left there a few API related questions, but I didn't get too deep into the logic itself, other than just the validation bits.

vertical-pod-autoscaler/pkg/admission-controller/main.go

soltysh · 2025-11-19T10:41:06Z

vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1/types.go

+	// +required
+	Type StartupBoostType `json:"type" protobuf:"bytes,1,opt,name=type"`
+	// factor specifies the factor to apply to the resource request.
+	// This field is to be used only when Type is "Factor".


Suggested change

// This field is to be used only when Type is "Factor".

// This field is required when Type is "Factor".

soltysh · 2025-11-19T10:41:18Z

vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1/types.go

+
+	// quantity specifies the absolute resource quantity to be used as the
+	// resource request and limit during the boost phase.
+	// This field is to be used only when Type is "Quantity".


Suggested change

// This field is to be used only when Type is "Quantity".

// This field is required when Type is "Quantity".

vertical-pod-autoscaler/pkg/utils/annotations/vpa_cpu_boost.go

soltysh · 2025-11-19T12:14:00Z

vertical-pod-autoscaler/pkg/admission-controller/resource/pod/patch/resource_updates_test.go

+			maxAllowedCpu:      resource.QuantityValue{},
+			featureGateEnabled: true,
+			expectError:        fmt.Errorf("boost factor must be >= 1"),
+		},


This is the only error case you're testing, I'd add additional ones for type and factor|quantity specified, and probably also one for invalid type, even though that should be caught at the api server validation, but it doesn't hurt to have a test case covering that.

The other thing, the WithCPUStartupBoost method only modifies the VPA.spec, but doesn't change the container level StartupBoost, it would be good to also cover that case in test, to ensure the latter takes priority.

What is the relationship between the two, I missed that in the AEP-7862 and the code seems to be working on one or the other, depending on the location?

Added some more error cases in #8828. should it error out when both quantity and Factor are set ? Currently it doesnt.

contianer level startup boost has higher priority, added some test cases to cover that.

kamarabbas99 and others added 8 commits November 11, 2025 10:34

Introduce API changes and fetaure gate CPU startup boost

c1a42db

Apply CPU startup boost in admission controller if its set

0554a5c

Fix VPA startup boost validation error messages

30aebbe

Fix VPA startup boost validation error messages

Make changes to updater to add the unboosting logic

b25e43c

Fix test failure after rebase

3512961

Merge pull request #8797 from kamarabbas99/clean_fix_for_experimental

18d8efd

Fix test failure after rebase

Add e2e tests for CPU startup boost

202579b

Merge pull request #8672 from kamarabbas99/feature-cpu-e2e

cd061df

Add e2e tests for CPU startup boost

k8s-ci-robot requested review from andrewsykim and kwiesmueller November 13, 2025 20:23

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 13, 2025

k8s-ci-robot requested review from adrianmoisey and omerap12 November 13, 2025 20:23

omerap12 reviewed Nov 13, 2025

View reviewed changes

k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 13, 2025

k8s-ci-robot assigned omerap12 Nov 13, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2025

adrianmoisey reviewed Nov 14, 2025

View reviewed changes

vertical-pod-autoscaler/docs/features.md Outdated Show resolved Hide resolved

adrianmoisey reviewed Nov 14, 2025

View reviewed changes

vertical-pod-autoscaler/docs/features.md Outdated Show resolved Hide resolved

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2025

k8s-ci-robot requested a review from soltysh November 14, 2025 06:56

Update VPA version for startupboost feature

e8b925e

kamarabbas99 mentioned this pull request Nov 14, 2025

Update VPA version for startupboost feature #8815

Merged

Merge pull request #8815 from kamarabbas99/experimental-cpu-boost-v2

4b40a55

Update VPA version for startupboost feature

k8s-ci-robot assigned adrianmoisey Nov 16, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2025

k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label Nov 19, 2025

github-project-automation bot added this to API Reviews Nov 19, 2025

soltysh moved this to Backlog in API Reviews Nov 19, 2025

soltysh reviewed Nov 19, 2025

View reviewed changes

kamarabbas99 added a commit to kamarabbas99/autoscaler that referenced this pull request Nov 19, 2025

Address comments on kubernetes#8813

9cbd887

kamarabbas99 mentioned this pull request Nov 19, 2025

Address comments on PR 8813 #8828

Open

kamarabbas99 added a commit to kamarabbas99/autoscaler that referenced this pull request Nov 19, 2025

Address comments on kubernetes#8813

1c2f5c0

	// This field is to be used only when Type is "Factor".
	// This field is required when Type is "Factor".

feat: CPU startup boost in master #8813

Are you sure you want to change the base?

feat: CPU startup boost in master #8813

Conversation

kamarabbas99 commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Which issue(s) this PR fixes:

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

kamarabbas99 commented Nov 13, 2025

Uh oh!

k8s-triage-robot commented Nov 13, 2025

Uh oh!

omerap12 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

omerap12 commented Nov 14, 2025

Uh oh!

adrianmoisey commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adrianmoisey commented Nov 16, 2025

Uh oh!

omerap12 commented Nov 16, 2025

Uh oh!

k8s-ci-robot commented Nov 16, 2025

Uh oh!

soltysh commented Nov 19, 2025

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

soltysh Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

soltysh Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

kamarabbas99 Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

soltysh Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

soltysh Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

soltysh Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

kamarabbas99 Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

kamarabbas99 commented Nov 13, 2025 •

edited

Loading

adrianmoisey commented Nov 14, 2025 •

edited

Loading

kamarabbas99 Nov 19, 2025 •

edited

Loading