Skip to content

Commit

Permalink
Merge pull request #1030 from cartermckinnon/misleading-log
Browse files Browse the repository at this point in the history
ecr-credential-provider: Fix warning about no region in image ref
  • Loading branch information
k8s-ci-robot authored Jan 27, 2025
2 parents c9d7595 + 3efcee2 commit b1f753a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmd/ecr-credential-provider/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,11 @@ func defaultECRProvider(ctx context.Context, region string) (ECR, error) {
var cfg aws.Config
var err error
if region != "" {
klog.Warningf("No region found in the image reference, the default region will be used. Please refer to AWS SDK documentation for configuration purpose.")
cfg, err = config.LoadDefaultConfig(ctx,
config.WithRegion(region),
)
} else {
klog.Warningf("No region found in the image reference, the default region will be used. Please refer to AWS SDK documentation for configuration purpose.")
cfg, err = config.LoadDefaultConfig(ctx)
}

Expand Down

0 comments on commit b1f753a

Please sign in to comment.