Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go version to 1.21.5 #764

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

oliviassss
Copy link
Contributor

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
update go version to fix the failure in govlun check.
Which issue(s) this PR fixes:

Logs of a failed govlun check: https://github.com/kubernetes/cloud-provider-aws/actions/runs/7167984447/job/19515167548?pr=763
Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 11, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 11, 2023
@cartermckinnon
Copy link
Contributor

/lgtm
/approve

@oliviassss Can you open cherry-picks for this as well?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cartermckinnon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit 229bc05 into kubernetes:master Dec 11, 2023
5 checks passed
@oliviassss
Copy link
Contributor Author

@cartermckinnon, sure, which branch should I cherry pick to?

@cartermckinnon
Copy link
Contributor

cartermckinnon commented Dec 11, 2023

We should probably go all the way back to 1.23, I think every active branch is on go 1.21 now.

You can use the cherry pick script to open them quickly: https://kops.sigs.k8s.io/contributing/proposing-a-cherry-pick/

k8s-ci-robot added a commit that referenced this pull request Dec 25, 2023
Cherry pick #791 update golang.org/x/crypto to v0.17.0 and #764 update go version to 1.21.5
k8s-ci-robot added a commit that referenced this pull request Dec 25, 2023
Cherry pick #791 update golang.org/x/crypto to v0.17.0 and #764 update go version to 1.21.5
k8s-ci-robot added a commit that referenced this pull request Dec 25, 2023
Cherry pick #791 update golang.org/x/crypto to v0.17.0 and #764 update go version to 1.21.5
k8s-ci-robot added a commit that referenced this pull request Dec 25, 2023
Cherry pick #791 update golang.org/x/crypto to v0.17.0 and #764 update go version to 1.21.5
k8s-ci-robot added a commit that referenced this pull request Dec 25, 2023
Cherry pick #791 update golang.org/x/crypto to v0.17.0 and #764 update go version to 1.21.5
k8s-ci-robot added a commit that referenced this pull request Dec 26, 2023
Cherry pick #791 update golang.org/x/crypto to v0.17.0 and #764 update go version to 1.21.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants