Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moving predicates ordering design proposal under scheduling directory #1302

Merged
merged 1 commit into from
Oct 30, 2017
Merged

moving predicates ordering design proposal under scheduling directory #1302

merged 1 commit into from
Oct 30, 2017
+0 −0

Conversation

yastij
Copy link
Member

@yastij yastij commented Oct 30, 2017

/cc @bsalamat

sorry for the delay

@k8s-ci-robot k8s-ci-robot requested a review from bsalamat October 30, 2017 21:39
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 30, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @yastij. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 30, 2017
@cblecker
Copy link
Member

/lgtm
based on #1152 (comment)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 5af3d6b into kubernetes:master Oct 30, 2017
MadhavJivrajani pushed a commit to MadhavJivrajani/community that referenced this pull request Nov 30, 2021
Merge pull request kubernetes#1302 from yastij/moving-predicates-desi…
7346d46 
…gn-proposal

Automatic merge from submit-queue.

moving predicates ordering design proposal under scheduling directory

/cc @bsalamat 

sorry for the delay
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsalamat bsalamat Awaiting requested review from bsalamat

Assignees

@timothysc timothysc

@cblecker cblecker

@davidopp davidopp

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yastij @k8s-ci-robot @cblecker @k8s-github-robot @timothysc @davidopp