docs: update default-branch-migration.md #5688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
specifically - remove reference to prow retriggering presubmits on PR rename (thanks for the fix GitHub! ❤️) - add links to issues for bootstrap and pod-utils not supporting default branch as a concept - add snippets showing how to auto-detect remote branch - misc rewording or rephrasing
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/cc @nikhita @cblecker @mrbobbytables |
There was a problem hiding this comment.
Thanks @spiffxp!
/lgtm
/hold
in case any others have comments 👍
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
specifically
for the fix GitHub! ❤️)
branch as a concept
At least some of this is based on my experience migrating
kubernetes-sigs/slack-infra (ref:
kubernetes-sigs/slack-infra#50)
ref: #5636 as the general
feedback issue for these docs, thought I didn't specifically address any of
the items there as part of this
fixes: #5619