-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-4786: Direct cgroup stats collection on Node #4787
Conversation
linxiulei
commented
Aug 12, 2024
- One-line PR description: Direct cgroup stats collection on Node
- Issue link: Direct cgroup stats collection #4786
- Other comments:
3c58dfe
to
71ee6d2
Compare
[#18044]: https://github.com/kubernetes/kubernetes/issues/18044 | ||
[#124520]: https://github.com/kubernetes/kubernetes/pull/124520 | ||
|
||
### Goals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this work related: kubernetes/kubernetes#107960?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems related. Added.
|
||
## Proposal | ||
|
||
This KEP only involves changes in Kubelet so it's trivial to move logic from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is the overhead reduction will come from? Can you please add details?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added details, PTAL!
There's a proposal floating about getting the stats from the container runtime, but I don't remember the details atm |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: linxiulei The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/reopen |
@linxiulei: Failed to re-open PR: state cannot be changed. There are no new commits on the linxiulei:master branch. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/reopen |
@linxiulei: Failed to re-open PR: state cannot be changed. There are no new commits on the linxiulei:master branch. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/reopen |
@linxiulei: Failed to re-open PR: state cannot be changed. There are no new commits on the linxiulei:master branch. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
reopen |
hmm, can't reopen it so had to create a new PR #4792 |