Skip to content

KEP-3243: Update milestone v1.33 to v1.34 and add the new feature gate to control the design change of TopologySpreadConstraint's matchLabelKeys #5205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 18, 2025
Merged

KEP-3243: Update milestone v1.33 to v1.34 and add the new feature gate to control the design change of TopologySpreadConstraint's matchLabelKeys #5205

merged 6 commits into from
Jun 18, 2025
+43 −13

Conversation

mochizuki875
Copy link
Member

@mochizuki875 mochizuki875 commented Mar 14, 2025 •
edited
Loading

One-line PR description: Update KEP milestone v1.33 to v1.34 since the code change have not meet the v1.33 code freeze, and I've added the new feature gate for #129874 as discussed in kubernetes/kubernetes#129874 (comment).
Issue link: #3243
Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 14, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and Huang-Wei March 14, 2025 05:33
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Mar 14, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Scheduling Mar 14, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 14, 2025
@mochizuki875
Copy link
Member Author

/cc @sanposhiho
/cc @alculquicondor
/cc @deads2k

@mochizuki875 mochizuki875 changed the title KEP-3243: Add the new feature gate for #129874 KEP-3243: Add the new feature gate to control the design change of TopologySpreadConstraint's matchLabelKeys Mar 14, 2025
@mochizuki875 mochizuki875 mentioned this pull request Mar 14, 2025
Merged
@mochizuki875 mochizuki875 force-pushed the kep-3243-add-MatchLabelKeysInPodTopologySpreadMutation-featuregate branch from 1a3dbd2 to 4e8004a Compare March 14, 2025 08:26
This was referenced Mar 17, 2025
Closed
Closed
@sanposhiho
Copy link
Member

/cc @macsko @dom4ha

@k8s-ci-robot k8s-ci-robot requested review from dom4ha and macsko March 21, 2025 05:38
@mochizuki875 mochizuki875 force-pushed the kep-3243-add-MatchLabelKeysInPodTopologySpreadMutation-featuregate branch from 4e8004a to 39ebbdc Compare March 21, 2025 08:44
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 21, 2025
@mochizuki875 mochizuki875 changed the title KEP-3243: Add the new feature gate to control the design change of TopologySpreadConstraint's matchLabelKeys KEP-3243: Update milestone v1.33 to v1.34 and add the new feature gate to control the design change of TopologySpreadConstraint's matchLabelKeys Mar 21, 2025
@mochizuki875
Copy link
Member Author

I've merged #5214 into this change.

sanposhiho
sanposhiho reviewed Mar 22, 2025
View reviewed changes
@mochizuki875 mochizuki875 force-pushed the kep-3243-add-MatchLabelKeysInPodTopologySpreadMutation-featuregate branch from b154ec0 to 8148d60 Compare March 24, 2025 06:10
@mochizuki875
Copy link
Member Author

/cc @sanposhiho
/cc @macsko
/cc @dom4ha

@k8s-ci-robot k8s-ci-robot requested review from macsko and sanposhiho May 4, 2025 08:08
@alculquicondor alculquicondor removed their request for review May 5, 2025 13:25
sanposhiho
sanposhiho reviewed May 17, 2025
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2025
@mochizuki875 mochizuki875 mentioned this pull request May 30, 2025
Merged
@wojtek-t wojtek-t self-assigned this Jun 6, 2025
@macsko
Copy link
Member

macsko commented Jun 9, 2025

/approve

/hold
Do we need a PRR review? I see @wojtek-t is assigned

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: macsko, mochizuki875

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2025
@mochizuki875 mochizuki875 mentioned this pull request Jun 10, 2025
Open
12 tasks
@mochizuki875
Copy link
Member Author

mochizuki875 commented Jun 10, 2025 •
edited
Loading

@wojtek-t
PTAL?(related #3243 (comment))
Please let me know if there's anything I need to do.

@kannon92
Copy link
Contributor

@wojtek-t PTAL?(related #3243 (comment)) Please let me know if there's anything I need to do.

If this is going from beta -> stable than I think a PRR review is required. If you are staying in beta, I am not sure a PRR review is required.

I did take a look on this.

Can you update the following question?

https://github.com/kubernetes/enhancements/blob/21b4a20df19c40659a93509918e61306f38a935e/keps/sig-scheduling/3243-respect-pod-topology-spread-after-rolling-upgrades/README.md#are-there-any-missing-metrics-that-would-be-useful-to-have-to-improve-observability-of-this-feature

The issue merged so I think this could be updated.

@mochizuki875
Copy link
Member Author

@kannon92
Thank you for your comment!
I'll make the update later.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2025
@mochizuki875
Copy link
Member Author

@kannon92
OK, I've addressed.

@sanposhiho @macsko
It seems that the issue(#110643) related to this question has been resolved by the merging of #115082 and #118025.
So I've update the answer of PRR question.

sanposhiho
sanposhiho reviewed Jun 11, 2025
View reviewed changes
keps/sig-scheduling/3243-respect-pod-topology-spread-after-rolling-upgrades/README.md Outdated
@@ -897,8 +897,7 @@ Pick one more of these and delete the rest.
Describe the metrics themselves and the reasons why they weren't added (e.g., cost,
implementation difficulties, etc.).
-->
Yes. It's helpful if we have the metrics to see which plugins affect to scheduler's decisions in Filter/Score phase.
There is the related issue: https://github.com/kubernetes/kubernetes/issues/110643 . It's very big and still on the way.
No.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: to make it clear

Yes, [there were](https://github.com/kubernetes/kubernetes/issues/110643), and it's been implemented in xxx and yyy.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I've updated.

@sanposhiho
Copy link
Member

/lgtm

Keep /hold for PRR reviewer

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2025
@wojtek-t
Copy link
Member

/lgtm from PRR perspective

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2025
@k8s-ci-robot k8s-ci-robot merged commit 119b531 into kubernetes:master Jun 18, 2025
2 of 4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 18, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in SIG Scheduling Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanposhiho sanposhiho sanposhiho left review comments

@ahg-g ahg-g Awaiting requested review from ahg-g

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

@deads2k deads2k Awaiting requested review from deads2k

@dom4ha dom4ha Awaiting requested review from dom4ha

@macsko macsko Awaiting requested review from macsko

Assignees

@wojtek-t wojtek-t

@sanposhiho sanposhiho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Scheduling
Archived in project
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
6 participants
@mochizuki875 @sanposhiho @macsko @k8s-ci-robot @kannon92 @wojtek-t