KEP-3085: continue beta in 1.35 #5552

Priyankasaggu11929 · 2025-09-20T15:14:09Z

One-line PR description: Promote KEP 3085 to GA in 1.35.

Issue link: [KEP-3085] Add condition for sandbox creation (xposted from original issue) #4138

Other comments:

Priyankasaggu11929 · 2025-09-22T07:31:39Z

cc: @kannon92 for review. Thanks!

Priyankasaggu11929 · 2025-09-22T07:32:06Z

/assign @kannon92

Priyankasaggu11929 · 2025-09-23T06:12:27Z

keps/sig-node/3085-pod-conditions-for-starting-completition-of-sandbox-creation/README.md

 - [] Volume Mounting Issues
  - [x] Add test to verify sandbox condition for missing configmap.
+    (added as part of [k/k PR#121321](https://github.com/kubernetes/kubernetes/pull/121321))
  - [ ] Add test to verify sandbox condition for missing secret.


- [ ] Add test to verify sandbox condition for missing secret.

This pending test is addressed by kubernetes/kubernetes#134179

kannon92

/lgtm

/assign @SergeyKanzhelev @mrunalp @dchen1107

SergeyKanzhelev · 2025-10-01T01:50:03Z

keps/sig-node/3085-pod-conditions-for-starting-completition-of-sandbox-creation/kep.yaml

 see-also:
  - none
 replaces:
  - none


please update reviewers and approvers for this KEP (or add more)

Addressed in 2f2f993

Added all three SIG leads mentioned in #5552 (review) along with existing approver/reviewer.

SergeyKanzhelev · 2025-10-01T01:51:35Z

keps/sig-node/3085-pod-conditions-for-starting-completition-of-sandbox-creation/README.md


 - Alpha in 1.25.
 - PodHasNetwork renamed to PodReadyToStartContainers in 1.28.
 - Beta promotion to 1.29


Is there any use we know of for this condition? GA criteria is not asking for the adoption, but it is a good validation that actually useful condition and there is no "open discussions" that are required by the criteria

It’s more informational.

#4138 (comment)

@gjkim42 pointed out that it is being used by external controllers. I have not received any feedback on this feature (positive or negative).

Priyankasaggu11929 · 2025-10-07T04:33:42Z

keps/prod-readiness/sig-node/3085.yaml

+stable:
+  approver: "@johnbelamaric"


@johnbelamaric, just a note – I have added you as PRR approver for stable as you did the last 2 for alpha and beta graduations as well. Thanks!

SergeyKanzhelev

/lgtm
/approve

SergeyKanzhelev · 2025-10-07T05:22:42Z

/lgtm /approve

/lgtm cancel

cancelling because of this Slack bug report: https://kubernetes.slack.com/archives/C0BP8PW9G/p1759798061245579

I don't think it was designed to wait for the image pull.

kannon92 · 2025-10-07T17:24:40Z

kubernetes/kubernetes#134460 was created so some investigation is needed.

haircommander · 2025-10-08T16:52:38Z

as discussed in SIG node yesterday, I believe we're doing another beta of this to address the aforementioned bug and thus be able to better test it. Is that correct @Priyankasaggu11929 ? if so, can you update this to reflect that?

Priyankasaggu11929 · 2025-10-09T04:46:29Z

as discussed in SIG node yesterday, I believe we're doing another beta of this to address the aforementioned bug and thus be able to better test it. Is that correct @Priyankasaggu11929 ? if so, can you update this to reflect that?

yes, updated the KEP to just reflect the latest_milestone as v1.35 in 0199757.
Also removed the PRR approval bit for stable.

SergeyKanzhelev · 2025-10-09T07:15:04Z

keps/sig-node/3085-pod-conditions-for-starting-completition-of-sandbox-creation/kep.yaml

  - "@derekwaynecarr"
  - "@aojea"
+  - "@SergeyKanzhelev"
+  - "@dchen1107"
+  - "@mrunalp"


Suggested change

- "@derekwaynecarr"

- "@aojea"

- "@SergeyKanzhelev"

- "@dchen1107"

- "@mrunalp"

- "@aojea"

- "@mrunalp"

Let's keep the list or approvers shorter.

updated in 6cde0a9

SergeyKanzhelev · 2025-10-09T07:16:26Z

keps/sig-node/3085-pod-conditions-for-starting-completition-of-sandbox-creation/README.md

 - PodHasNetwork renamed to PodReadyToStartContainers in 1.28.
 - Beta promotion to 1.29
  - Moving PodReadyToStartContainers to staging/src/k8s.io/api/core/v1/types.go as a API constant
+  - Added e2e tests:


One more thing I wish we cover in 1.35 is the relationship of PodReadyToStartContainersCondition with the DRA. Let's document whether Allocate calls are before or after this condition is set and add a test for this

@SergeyKanzhelev, addressed in 5212909.

I updated the Beta graduation critera and list of e2e tests to add the requirements wrt DRA. Please review. Thanks!

Priyankasaggu11929 · 2025-10-15T04:30:48Z

@SergeyKanzhelev - ping for another round of review. Thanks!

SergeyKanzhelev · 2025-10-15T16:34:41Z

/lgtm

dchen1107 · 2025-10-15T16:52:38Z

/approve

k8s-ci-robot · 2025-10-15T16:52:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, Priyankasaggu11929, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~keps/sig-node/OWNERS~~ [dchen1107]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Priyankasaggu11929 added 3 commits September 20, 2025 20:36

add PRR approver for stable

03bfd8a

update kep.yaml for GA promotion

26f8c32

update Implementaion History in KEP README

a82692f

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 20, 2025

k8s-ci-robot requested review from jeremyrickard and mrunalp September 20, 2025 15:14

k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 20, 2025

Priyankasaggu11929 mentioned this pull request Aug 26, 2025

[KEP-3085] Add condition for sandbox creation (xposted from original issue) #4138

Open

20 tasks

k8s-ci-robot assigned kannon92 Sep 22, 2025

Priyankasaggu11929 commented Sep 23, 2025

View reviewed changes

kannon92 reviewed Sep 30, 2025

View reviewed changes

k8s-ci-robot assigned dchen1107, mrunalp and SergeyKanzhelev Sep 30, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2025

SergeyKanzhelev reviewed Oct 1, 2025

View reviewed changes

update reviewers, approvers in kep.yaml

2f2f993

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2025

Priyankasaggu11929 commented Oct 7, 2025

View reviewed changes

SergeyKanzhelev approved these changes Oct 7, 2025

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2025

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2025

update: continue beta in 1.35

0199757

Priyankasaggu11929 changed the title ~~KEP-3085: promote to GA in 1.35~~ KEP-3085: continue beta in 1.35 Oct 9, 2025

SergeyKanzhelev reviewed Oct 9, 2025

View reviewed changes

Priyankasaggu11929 added 2 commits October 9, 2025 16:27

update beta graduation criteria to include requirements wrt DRA

5212909

update approvers list in kep.yaml

6cde0a9

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2025

k8s-ci-robot merged commit 7d5ff18 into kubernetes:master Oct 15, 2025
4 checks passed

k8s-ci-robot added this to the v1.35 milestone Oct 15, 2025

KEP-3085: continue beta in 1.35 #5552

KEP-3085: continue beta in 1.35 #5552

Uh oh!

Conversation

Priyankasaggu11929 commented Sep 20, 2025

Uh oh!

Priyankasaggu11929 commented Sep 22, 2025

Uh oh!

Priyankasaggu11929 commented Sep 22, 2025

Uh oh!

Priyankasaggu11929 Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kannon92 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SergeyKanzhelev left a comment

Choose a reason for hiding this comment

Uh oh!

SergeyKanzhelev commented Oct 7, 2025

Uh oh!

kannon92 commented Oct 7, 2025

Uh oh!

haircommander commented Oct 8, 2025

Uh oh!

Priyankasaggu11929 commented Oct 9, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Priyankasaggu11929 commented Oct 15, 2025

Uh oh!

SergeyKanzhelev commented Oct 15, 2025

Uh oh!

dchen1107 commented Oct 15, 2025

Uh oh!

k8s-ci-robot commented Oct 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Priyankasaggu11929 Sep 23, 2025 •

edited

Loading