-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
script: Use instance zone instead of cluster location in setup-local script #2811
base: master
Are you sure you want to change the base?
Conversation
…e cluster's location
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: arvindbr8 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @arvindbr8! |
Hi @arvindbr8. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the improvement
@@ -37,7 +31,7 @@ if [ -z "$clusterLocation" ]; then | |||
else | |||
clusters=$(gcloud container clusters list --format="${fmt}" --filter="name:${clusterName} location:${clusterLocation}") | |||
fi | |||
if [ $(echo "${cluster}" | wc -l) -gt 1 ]; then | |||
if [ "$(echo "${clusters}" | wc -l)" -gt 1 ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Maybe change the variables to "cluster" since we really want this to have one value and use it in that manner in the rest of the script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. A followup to that: why do we use a gcloud container clusters list
, instead of gcloud container clusters describe
? That way we can get rid of the -gt 1
check and check for $? instead?
Fixes a bug that prevented the script from working with regional clusters.
Previously, the script incorrectly used the cluster's region as the instance group zone. This change now extracts the correct zone from the instance group's URL, ensuring compatibility with regional clusters.