Make the subset sizes configurable for L4 NetLB NEG. #2817
Conversation
Add `--l4-netlb-local-subset-size` and `--l4-netlb-local-subset-size` flags that allow to configure the subset sizes for the L4 NetLB endpoint calculators.
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mmamczur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
| @@ -35,10 +35,6 @@ const ( | |||
| maxSubsetSizeLocal = 250 | |||
| // Max number of subsets in ExternalTrafficPolicy:Cluster, which is the default mode. | |||
| maxSubsetSizeDefault = 25 | |||
| // Max number of subsets for NetLB in ExternalTrafficPolicy:Local | |||
There was a problem hiding this comment.
instead of removing completely, should there be a default if the flags are not provided?
There was a problem hiding this comment.
the flags have a default baked in. Maybe it would be nice to use these constants used in the flag def but I'm guessing it will make a circular dep then?
|
/retest weird faiure, locally tests seem to work bu then the failure looks like could potentially be caused by flags change? |
|
/retest |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Add
--l4-netlb-local-subset-sizeand--l4-netlb-local-subset-sizeflags that allow to configure the subset sizes for the L4 NetLB endpoint calculators.